Re: [PATCH/RFC] core.precomposeunicode is true by default

From: Duy Nguyen <pclouds@gmail.com>
Date: Jul 28, 2013, 04:45 UTC
Message-ID: <CACsJy8Dyaf0f5rk-NS_H-M8_t7WMGJyL+z_RaEYraGqbuZ+JiA@mail.gmail.com>
In-Reply-To: <51F44F4D.7030106@web.de>

On Sun, Jul 28, 2013 at 5:53 AM, Torsten Bögershausen <tboegi@web.de> wrote:

Show 17 quoted lines

>> Does this have any effects on non-utf8 users? I'm on utf-8, so this is
>> not really my concern, that is unless it changes something on LANG=C..
>>
> Not sure if I fully understand the question.
>
> Mac OS will always use UTF-8, and we can choose between
> precomposesd and decomposed.
>
> Windows ("Git for Windows" == msysgit) uses UTF-8 (precomposed)
> Git under cygwin 1.7 uses UTF-8, precomposed.
> Git under cygwin 1.5 or git compiled under mingw does not use
> UTF-8, but a Windows code page"
>
> Linux may use UTF-8 or ISO-8859 or whatever you configure.
>
> This change affects only Mac OS,
> (should this be stated better in the commit MSG?)

Ah yes, I see precompose_unicode changes default value from -1 to 1, but I did not see that the whole precompose unicode code is only active in Mac OS.

Show 6 quoted lines

>
> And if somebody wants to change a repo between Linux, Windows
> and/or Mac OS, everybody should use UTF-8 (precomposed) for filenames,
> directories and branches.
> (or stick to ASCII)
> Does this answer the question?

It does, thanks.

-- 
Duy