git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] core.precomposeunicode is true by default

From
Torsten Bögershausen <tboegi@web.de>
Date
Aug 27, 2013, 19:34 UTC
Message-ID
<521CFF31.9070607@web.de>
In-Reply-To
<xmqqhaebdrp6.fsf@gitster.dls.corp.google.com>
On 2013-08-27 18.27, Junio C Hamano wrote:
Show 33 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes:
> 
>>>> 2)
>>>> When we access a repo from Windows/Linux using SAMBA,
>>> You mean s/repo/repository that resides on HFS+/?
>> Sorry being unclear here, trying being clearer with an example:
>> I have a /data/Docs on my linux box, which is handled by git
>>
>> I export /data/Docs via SAMBA, and use the Finder under Mac OS to have it
>> mounted on my Mac OS X box:
>> //tb@Linux/Docs on /Volumes/Docs (smbfs, nodev, nosuid, mounted by tb)
>>>> readdir() will return decomposed.
>>>> When the repo is created by nonMacOS, core.precomposeunicode is undefined.
>>>> The precomposition is off, but should be on, 
>>>> precomposed_unicode = -1, but should be = 1
>>> I do not think UTF-8-MAC is widely available; even if you flip the
>>> bit on, would it help much?
>> In the above example
>> /data/Docs/.git/config was created by Linux, so it does not have
>> core.precomposeunicode set, neither false nor true.
>> The Linux box does not have  UTF-8-MAC under iconv,
>> but will ignore core.precomposeunicode anyway (since the code is not compiled here)
>>
>> The Mac OS machine sees it under /Volumes/Docs/.git/config
>> And here we want the precomposition, even if core.precomposeunicode
>> is not present in the config.
> 
> It almost makes me wonder if you want not a per-repository but a
> per-machine configuration, i.e. "Whichever repository I am
> accessing, either on a local filesystem or shared over the network,
> readdir() on my box reports wrong paths, and I need correction."
> 
> That, or "if it hurts, don't do the remote mount then."

No, we don't need to be that restrictive. We already have repository/user/system wide configuration files, allowing tweeks and this is a good thing.

Re-Re-reading $gmane/188940: I am happy having the V2 patch from today being queued, thanks.

As a next step I will have a look into the advice machine.
 
Previous: Junio C Hamano
Message 10 of 10 in “core.precomposeunicode is true by default”
  1. core.precomposeunicode is true by defaultTorsten Bögershausen, Jul 27, 2013
  2. Duy NguyenJul 27, 2013
  3. Torsten BögershausenJul 27, 2013
  4. Duy NguyenJul 28, 2013
  5. Junio C HamanoJul 29, 2013
  6. Torsten BögershausenAug 27, 2013
  7. Junio C HamanoAug 27, 2013
  8. Torsten BögershausenAug 27, 2013
  9. Junio C HamanoAug 27, 2013
  10. Torsten BögershausenAug 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.