Re: [PATCH/RFC] core.precomposeunicode is true by default

From: Torsten Bögershausen <tboegi@web.de>
Date: Jul 27, 2013, 22:53 UTC
Message-ID: <51F44F4D.7030106@web.de>
In-Reply-To: <CACsJy8AT--3Lus-3F4-8EHL_3--a-98RkJxaMMALaSjgV+D3WQ@mail.gmail.com>

On 2013-07-27 17.23, Duy Nguyen wrote:

Show 22 quoted lines

> On Sat, Jul 27, 2013 at 8:21 AM, Torsten Bögershausen <tboegi@web.de> wrote:
>> When core.precomposeunicode was introduced, it was set to false
>> by default, to be compatible with older versions of Git.
>>
>> Whenever UTF-8 file names are used in a mixed environment,
>> the Mac OS users need to find out that this configuration exist
>> and set it to true manually.
>>
>> There is no measurable performance impact between false and true.
>> A smoother workflow can be achieved for new Git users,
>> so change the default to true:
>>
>> - Remove the auto-sensing
>> - Rename the internal variable into precompose_unicode,
>>   and set it to 1 meaning true.
>> - Adjust and clean up test cases
>>
>> The configuration core.precomposeunicode is still supported.
> 
> Does this have any effects on non-utf8 users? I'm on utf-8, so this is
> not really my concern, that is unless it changes something on LANG=C..
>

Not sure if I fully understand the question.

Mac OS will always use UTF-8, and we can choose between precomposesd and decomposed.

Windows ("Git for Windows" == msysgit) uses UTF-8 (precomposed) Git under cygwin 1.7 uses UTF-8, precomposed. Git under cygwin 1.5 or git compiled under mingw does not use UTF-8, but a Windows code page"

Linux may use UTF-8 or ISO-8859 or whatever you configure.

This change affects only Mac OS, (should this be stated better in the commit MSG?)

And if somebody wants to change a repo between Linux, Windows and/or Mac OS, everybody should use UTF-8 (precomposed) for filenames, directories and branches. (or stick to ASCII) Does this answer the question? /Torsten