Re: [PATCH 00/19] Add git-list-files
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Dec 2, 2014, 11:33 UTC
- Message-ID
- <CACsJy8Do1PancG847KYnF-SZ=qq-=ubCG--QohYxm=+kUcMNNg@mail.gmail.com>
- In-Reply-To
- <xmqqbnnnp291.fsf@gitster.dls.corp.google.com>
On Tue, Dec 2, 2014 at 3:02 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Does this contain a lot of borrowed code or something? The style > violation in the patches are unusually high, even compared with your > other series.
The first one is from coreutils, but I reformatted (and trimmed) to fit Git. I recall you had a script to spot style violation, right? Where can I find the script? Else I'll reread CodingGuidlines again and go through the patch.
> I've tried to fix it up and will push out the result on 'pu' if > things work OK, but this does not even have tests, so it is unlikely > that it would break anything but itself ;-)
Heh.. ;) Next version will come with tests. Thanks for the reminder.
-- Duy