git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 07/19] ls-files: add --column

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Nov 30, 2014, 08:55 UTC
Message-ID
<1417337767-4505-8-git-send-email-pclouds@gmail.com>
In-Reply-To
<1417337767-4505-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 Documentation/git-ls-files.txt |  6 ++++++
 builtin/ls-files.c             | 28 ++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+)
diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt
index 148f226..99328b9 100644
--- a/Documentation/git-ls-files.txt
+++ b/Documentation/git-ls-files.txt
@@ -154,6 +154,12 @@ a space) at the start of each line:
 	`--color=never`. `--color` is equivalent to
 	`--color=auto`.
 
+--column[=<options>]::
+--no-column::
+	Display files in columns. See configuration variable column.ui
+	for option syntax. `--column` and `--no-column` without options
+	are equivalent to 'always' and 'never' respectively.
+
 \--::
 	Do not interpret any more arguments as options.
 
diff --git a/builtin/ls-files.c b/builtin/ls-files.c
index 4ddd49f..79e1944 100644
--- a/builtin/ls-files.c
+++ b/builtin/ls-files.c
@@ -15,6 +15,7 @@
 #include "string-list.h"
 #include "pathspec.h"
 #include "color.h"
+#include "column.h"
 
 static int abbrev;
 static int show_deleted;
@@ -29,6 +30,7 @@ static int show_valid_bit;
 static int line_terminator = '\n';
 static int debug_mode;
 static int use_color;
+static unsigned int colopts;
 
 static const char *prefix;
 static int max_prefix_len;
@@ -39,6 +41,7 @@ static char *ps_matched;
 static const char *with_tree;
 static int exc_given;
 static int exclude_args;
+static struct string_list output = STRING_LIST_INIT_NODUP;
 
 static const char *tag_cached = "";
 static const char *tag_unmerged = "";
@@ -66,6 +69,10 @@ static void write_name(struct strbuf *sb, const char *name)
 
 static void strbuf_fputs(struct strbuf *sb, FILE *fp)
 {
+	if (column_active(colopts)) {
+		string_list_append(&output, strbuf_detach(sb, NULL));
+		return;
+	}
 	fwrite(sb->buf, sb->len, 1, fp);
 }
 
@@ -552,6 +559,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
 		OPT_STRING(0, "with-tree", &with_tree, N_("tree-ish"),
 			N_("pretend that paths removed since <tree-ish> are still present")),
 		OPT__COLOR(&use_color, N_("show color")),
+		OPT_COLUMN(0, "column", &colopts, N_("show files in columns")),
 		OPT__ABBREV(&abbrev),
 		OPT_BOOL(0, "debug", &debug_mode, N_("show debugging data")),
 		OPT_END()
@@ -596,6 +604,18 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
 	if (dir.exclude_per_dir)
 		exc_given = 1;
 
+	finalize_colopts(&colopts, -1);
+	if (explicitly_enable_column(colopts)) {
+		if (!line_terminator)
+			die(_("--column and -z are incompatible"));
+		if (show_resolve_undo)
+			die(_("--column and --resolve-undo are incompatible"));
+		if (debug_mode)
+			die(_("--column and --debug are incompatible"));
+	}
+	if (column_active(colopts))
+		line_terminator = 0;
+
 	if (require_work_tree && !is_inside_work_tree())
 		setup_work_tree();
 
@@ -638,6 +658,14 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
 	if (show_resolve_undo)
 		show_ru_info();
 
+	if (column_active(colopts)) {
+		struct column_options copts;
+		memset(&copts, 0, sizeof(copts));
+		copts.padding = 2;
+		print_columns(&output, colopts, &copts);
+		string_list_clear(&output, 0);
+	}
+
 	if (ps_matched) {
 		int bad;
 		bad = report_path_error(ps_matched, &pathspec, prefix);
-- 
2.2.0.60.gb7b3c64
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 8 of 28 in “Add git-list-files”
  1. 00/19 Add git-list-filesNguyễn Thái Ngọc Duy, Nov 30, 2014
  2. 01/19 ls_colors.c: add $LS_COLORS parsing codeNguyễn Thái Ngọc Duy, Nov 30, 2014
  3. 02/19 ls_colors.c: parse color.ls.* from config fileNguyễn Thái Ngọc Duy, Nov 30, 2014
  4. 03/19 ls_colors.c: add a function to color a file nameNguyễn Thái Ngọc Duy, Nov 30, 2014
  5. 04/19 ls_colors.c: highlight submodules like directoriesNguyễn Thái Ngọc Duy, Nov 30, 2014
  6. 05/19 ls-files: buffer full item in strbuf before printingNguyễn Thái Ngọc Duy, Nov 30, 2014
  7. 06/19 ls-files: add --color to highlight file namesNguyễn Thái Ngọc Duy, Nov 30, 2014
  8. 07/19 ls-files: add --columnNguyễn Thái Ngọc Duy, Nov 30, 2014
  9. 08/19 ls-files: support --max-depthNguyễn Thái Ngọc Duy, Nov 30, 2014
  10. 09/19 Add git-list-files, a user friendly version of ls-files and moreNguyễn Thái Ngọc Duy, Nov 30, 2014
  11. Eric SunshineDec 2, 2014
  12. Duy NguyenDec 2, 2014
  13. 10/19 list-files: -u does not imply showing stagesNguyễn Thái Ngọc Duy, Nov 30, 2014
  14. 11/19 list-files: add -R/--recursive short for --max-depth=-1Nguyễn Thái Ngọc Duy, Nov 30, 2014
  15. 12/19 list-files: add -1 short for --no-columnNguyễn Thái Ngọc Duy, Nov 30, 2014
  16. 13/19 list-files: add -t backNguyễn Thái Ngọc Duy, Nov 30, 2014
  17. 14/19 list-files: sort output and remove duplicatesNguyễn Thái Ngọc Duy, Nov 30, 2014
  18. 15/19 list-files: do not show duplicate cached entriesNguyễn Thái Ngọc Duy, Nov 30, 2014
  19. 16/19 list-files: show directories as well as filesNguyễn Thái Ngọc Duy, Nov 30, 2014
  20. 17/19 list-files: add -F/--classifyNguyễn Thái Ngọc Duy, Nov 30, 2014
  21. 18/19 list-files -F: show submodules with the new indicator '&'Nguyễn Thái Ngọc Duy, Nov 30, 2014
  22. 19/19 list-files: -M aka diff-cachedNguyễn Thái Ngọc Duy, Nov 30, 2014
  23. Junio C HamanoDec 1, 2014
  24. Duy NguyenDec 2, 2014
  25. Jeff KingDec 2, 2014
  26. Duy NguyenDec 2, 2014
  27. Jeff KingDec 2, 2014
  28. Michael J GruberDec 2, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.