git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 16/19] list-files: show directories as well as files

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Nov 30, 2014, 08:56 UTC
Message-ID
<1417337767-4505-17-git-send-email-pclouds@gmail.com>
In-Reply-To
<1417337767-4505-1-git-send-email-pclouds@gmail.com>

The index does not store directories explicitly (except submodules) so we have to figure them out from file list. The function show_directories() deliberately generates duplicate directories and expects the previous patch to remove duplicates.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/ls-files.c | 44 +++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/builtin/ls-files.c b/builtin/ls-files.c
index fc70265..41efdaa 100644
--- a/builtin/ls-files.c
+++ b/builtin/ls-files.c
@@ -27,6 +27,8 @@ static int show_resolve_undo;
 static int show_modified;
 static int show_killed;
 static int show_valid_bit;
+static int show_tag;
+static int show_dirs;
 static int line_terminator = '\n';
 static int debug_mode;
 static int use_color;
@@ -333,6 +335,43 @@ static void show_files(struct dir_struct *dir)
 	}
 }
 
+static void show_directories(const struct cache_entry *ce)
+{
+	static const char *last_directory;
+	struct strbuf sb = STRBUF_INIT;
+	const char *p = ce->name + prefix_len;
+	const char *sep;
+
+	if (last_directory) {
+		int len = strlen(last_directory);
+		if (!strncmp(ce->name, last_directory, len) &&
+		    ce->name[len] == '/')
+			p += len + 1;
+	}
+
+	while (*p && (sep = strchr(p, '/'))) {
+		struct strbuf sb2 = STRBUF_INIT;
+		strbuf_reset(&sb);
+		strbuf_add(&sb, ce->name, sep - ce->name);
+		p = sep + 1;
+		if (!match_pathspec(&pathspec, sb.buf, sb.len,
+				    prefix_len, NULL, 1))
+			continue;
+		write_name(&sb2, sb.buf);
+		if (want_color(use_color)) {
+			struct strbuf sb3 = STRBUF_INIT;
+			color_filename(&sb3, ce->name, sb2.buf, S_IFDIR, 1);
+			strbuf_release(&sb2);
+			sb2 = sb3;
+		}
+		if (show_tag)
+			strbuf_insert(&sb2, 0, tag_cached, strlen(tag_cached));
+		last_directory = strbuf_detach(&sb, NULL);
+		strbuf_fputs(&sb2, last_directory, NULL);
+		strbuf_release(&sb2);
+	}
+}
+
 static void show_files_compact(struct dir_struct *dir)
 {
 	int i;
@@ -353,6 +392,8 @@ static void show_files_compact(struct dir_struct *dir)
 		const struct cache_entry *ce = active_cache[i];
 		struct stat st;
 		int err, shown = 0;
+		if (show_dirs)
+			show_directories(ce);
 		if ((dir->flags & DIR_SHOW_IGNORED) &&
 		    !ce_excluded(dir, ce))
 			continue;
@@ -575,7 +616,7 @@ static int git_ls_config(const char *var, const char *value, void *cb)
 
 int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
 {
-	int require_work_tree = 0, show_tag = 0, i;
+	int require_work_tree = 0, i;
 	int max_depth = -1;
 	const char *max_prefix;
 	struct dir_struct dir;
@@ -696,6 +737,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
 		use_color = -1;
 		max_depth = 0;
 		show_tag = -1;
+		show_dirs = 1;
 		git_config(git_ls_config, NULL);
 	} else
 		git_config(git_default_config, NULL);
-- 
2.2.0.60.gb7b3c64
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 19 of 28 in “Add git-list-files”
  1. 00/19 Add git-list-filesNguyễn Thái Ngọc Duy, Nov 30, 2014
  2. 01/19 ls_colors.c: add $LS_COLORS parsing codeNguyễn Thái Ngọc Duy, Nov 30, 2014
  3. 02/19 ls_colors.c: parse color.ls.* from config fileNguyễn Thái Ngọc Duy, Nov 30, 2014
  4. 03/19 ls_colors.c: add a function to color a file nameNguyễn Thái Ngọc Duy, Nov 30, 2014
  5. 04/19 ls_colors.c: highlight submodules like directoriesNguyễn Thái Ngọc Duy, Nov 30, 2014
  6. 05/19 ls-files: buffer full item in strbuf before printingNguyễn Thái Ngọc Duy, Nov 30, 2014
  7. 06/19 ls-files: add --color to highlight file namesNguyễn Thái Ngọc Duy, Nov 30, 2014
  8. 07/19 ls-files: add --columnNguyễn Thái Ngọc Duy, Nov 30, 2014
  9. 08/19 ls-files: support --max-depthNguyễn Thái Ngọc Duy, Nov 30, 2014
  10. 09/19 Add git-list-files, a user friendly version of ls-files and moreNguyễn Thái Ngọc Duy, Nov 30, 2014
  11. Eric SunshineDec 2, 2014
  12. Duy NguyenDec 2, 2014
  13. 10/19 list-files: -u does not imply showing stagesNguyễn Thái Ngọc Duy, Nov 30, 2014
  14. 11/19 list-files: add -R/--recursive short for --max-depth=-1Nguyễn Thái Ngọc Duy, Nov 30, 2014
  15. 12/19 list-files: add -1 short for --no-columnNguyễn Thái Ngọc Duy, Nov 30, 2014
  16. 13/19 list-files: add -t backNguyễn Thái Ngọc Duy, Nov 30, 2014
  17. 14/19 list-files: sort output and remove duplicatesNguyễn Thái Ngọc Duy, Nov 30, 2014
  18. 15/19 list-files: do not show duplicate cached entriesNguyễn Thái Ngọc Duy, Nov 30, 2014
  19. 16/19 list-files: show directories as well as filesNguyễn Thái Ngọc Duy, Nov 30, 2014
  20. 17/19 list-files: add -F/--classifyNguyễn Thái Ngọc Duy, Nov 30, 2014
  21. 18/19 list-files -F: show submodules with the new indicator '&'Nguyễn Thái Ngọc Duy, Nov 30, 2014
  22. 19/19 list-files: -M aka diff-cachedNguyễn Thái Ngọc Duy, Nov 30, 2014
  23. Junio C HamanoDec 1, 2014
  24. Duy NguyenDec 2, 2014
  25. Jeff KingDec 2, 2014
  26. Duy NguyenDec 2, 2014
  27. Jeff KingDec 2, 2014
  28. Michael J GruberDec 2, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.