git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] sequencer: trivial fix

From
Duy Nguyen <pclouds@gmail.com>
Date
May 29, 2013, 13:42 UTC
Message-ID
<CACsJy8Do-djwjVP1YvGnvsbdiWjE47KTK4pZZ3Qdnubvd-r3Lw@mail.gmail.com>
In-Reply-To
<CAMP44s0cpAkAUzo0nS55yv+6=cCBsBhgNiYxpEd8Hzk=3mfNhw@mail.gmail.com>

On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 16 quoted lines
> On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen <pclouds@gmail.com> wrote:
>> On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras
>> <felipe.contreras@gmail.com> wrote:
>>> We should free objects before leaving.
>>>
>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>
>> Micronit: perhaps you should move the "free obejcts before leaving"
>> (in do_pick_commit) to the subject instead of "trivial fix", which
>> adds no value to the patch.
>
> Perhaps. I prefer it this way because it's really a trivial fix not
> really worth much time thinking about it. So when somebody is browsing
> the history they can happily skip this one. The time save by not
> reading I think adds more value than any succinct description that
> would force each and every patch-reviewer/history-reader to read it.

Some time from now, assume a ridiculus case when this function grows more complex and somebody wonders what the "leave" label is for, "git log --oneline -Slabel:" showing "trivial fix" would not help much. -- Duy

Previous: Felipe ContrerasNext: Felipe Contreras
Message 15 of 21 in “cherry-pick: a fix and a new option”
  1. 0/2 cherry-pick: a fix and a new optionFelipe Contreras, May 27, 2013
  2. 1/2 sequencer: trivial fixFelipe Contreras, May 27, 2013
  3. Neil HormanMay 28, 2013
  4. Junio C HamanoMay 28, 2013
  5. Felipe ContrerasMay 29, 2013
  6. Joachim SchmitzMay 29, 2013
  7. Felipe ContrerasMay 29, 2013
  8. Joachim SchmitzMay 29, 2013
  9. Felipe ContrerasMay 29, 2013
  10. Joachim SchmitzMay 29, 2013
  11. Joachim SchmitzMay 29, 2013
  12. Neil HormanMay 29, 2013
  13. Duy NguyenMay 29, 2013
  14. Felipe ContrerasMay 29, 2013
  15. Duy NguyenMay 29, 2013
  16. Felipe ContrerasMay 29, 2013
  17. Duy NguyenMay 29, 2013
  18. Felipe ContrerasMay 29, 2013
  19. 2/2 cherry-pick: add --skip-commits optionFelipe Contreras, May 27, 2013
  20. Joachim SchmitzMay 28, 2013
  21. Neil HormanMay 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.