From: Duy Nguyen Date: Wed, 29 May 2013 13:42:18 GMT Subject: Re: [PATCH 1/2] sequencer: trivial fix Message-ID: In-Reply-To: On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras wrote: > On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen wrote: >> On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras >> wrote: >>> We should free objects before leaving. >>> >>> Signed-off-by: Felipe Contreras >> >> Micronit: perhaps you should move the "free obejcts before leaving" >> (in do_pick_commit) to the subject instead of "trivial fix", which >> adds no value to the patch. > > Perhaps. I prefer it this way because it's really a trivial fix not > really worth much time thinking about it. So when somebody is browsing > the history they can happily skip this one. The time save by not > reading I think adds more value than any succinct description that > would force each and every patch-reviewer/history-reader to read it. Some time from now, assume a ridiculus case when this function grows more complex and somebody wonders what the "leave" label is for, "git log --oneline -Slabel:" showing "trivial fix" would not help much. -- Duy