Re: [PATCH] Correct singular form in diff summary line for human interaction
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Feb 1, 2012, 01:32 UTC
- Message-ID
- <CACsJy8Dd4_Pnvzxww38EfZt8NgRow+qxCReohc45XoNpfJCbYg@mail.gmail.com>
- In-Reply-To
- <7vvcnr92y0.fsf@alter.siamese.dyndns.org>
On Wed, Feb 1, 2012 at 12:50 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
>> If there is an environment variable to say "I don't want to see >> variations on strings intended for humans", can it be spelled as >> LC_ALL=C? > > ... > > If we were to touch this, I would prefer to do so unconditionally without > "hrm, can we reliably guess this is meant for humans?" and release it > unceremoniously, perhaps as part of the next release that will have a much > bigger user-visible UI correction to 'merge'.
Unconditionally change is fine to me. There's another implication that's not mentioned in the commit message, this change also allows non-English translations. Any objections on i18n or we just keep this line English only? Personally if scripts do not matter any more, I see no reasons this line cannot be translated.
-- Duy