[PATCH 5/7] test: use --numstat instead of --stat in "git stash show" tests
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Mar 13, 2012, 05:01 UTC
- Message-ID
- <20120313050132.GE12550@burratino>
- In-Reply-To
- <20120313045100.GA12474@burratino>
git's diff --stat output is intended for human consumption and since v1.7.9.2~13 (2012-02-01) varies by locale. Add a test checking that git stash show defaults to --stat and tweak the rest of the "stash show" tests that showed a diffstat to use numstat.
This way, there are fewer tests to tweak if the diffstat format changes again. This also improves test coverage when running tests with git configured not to write its output in the C locale (e.g., via GETTEXT_POISON=Yes).
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- t/t3903-stash.sh | 36 ++++++++++++++++++++++++------------ 1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh index c69e4da1..3addb804 100755 --- a/t/t3903-stash.sh +++ b/t/t3903-stash.sh @@ -432,6 +432,24 @@ test_expect_success 'stash branch - stashes on stack, stash-like argument' ' test $(git ls-files --modified | wc -l) -eq 1 ' +test_expect_success 'stash show format defaults to --stat' ' + git stash clear && + test_when_finished "git reset --hard HEAD" && + git reset --hard && + echo foo >> file && + git stash && + test_when_finished "git stash drop" && + echo bar >> file && + STASH_ID=$(git stash create) && + git reset --hard && + cat >expected <<-EOF && + file | 1 + + 1 file changed, 1 insertion(+) + EOF + git stash show ${STASH_ID} >actual && + test_i18ncmp expected actual +' + test_expect_success 'stash show - stashes on stack, stash-like argument' ' git stash clear && test_when_finished "git reset --hard HEAD" && @@ -442,12 +460,9 @@ test_expect_success 'stash show - stashes on stack, stash-like argument' ' echo bar >> file && STASH_ID=$(git stash create) && git reset --hard && - cat >expected <<-EOF && - file | 1 + - 1 file changed, 1 insertion(+) - EOF - git stash show ${STASH_ID} >actual && - test_i18ncmp expected actual + echo "1 0 file" >expected && + git stash show --numstat ${STASH_ID} >actual && + test_cmp expected actual ' test_expect_success 'stash show -p - stashes on stack, stash-like argument' ' @@ -480,12 +495,9 @@ test_expect_success 'stash show - no stashes on stack, stash-like argument' ' echo foo >> file && STASH_ID=$(git stash create) && git reset --hard && - cat >expected <<-EOF && - file | 1 + - 1 file changed, 1 insertion(+) - EOF - git stash show ${STASH_ID} >actual && - test_i18ncmp expected actual + echo "1 0 file" >expected && + git stash show --numstat ${STASH_ID} >actual && + test_cmp expected actual ' test_expect_success 'stash show -p - no stashes on stack, stash-like argument' '
-- 1.7.9.2