Re: [PATCH 2/2] i18n: bisect: mark two supplementary strings for translation

From: Duy Nguyen <pclouds@gmail.com>
Date: Jun 21, 2018, 14:48 UTC
Message-ID: <CACsJy8DcXo3HURwZXbvGYjrJpfku+RXESP=ErLzYj3NhNabRTQ@mail.gmail.com>
In-Reply-To: <20180621142742.28575-3-hertzog@debian.org>

On Thu, Jun 21, 2018 at 4:39 PM Raphaël Hertzog <hertzog@debian.org> wrote:

>
> The whole bisect procedure is translated but the last message
> that the user will see in the process is not translated. Let's fix this.

Nice. There's another string in bisect_common() that should also be translated: "revision walk setup failed". Maybe you can mark it too? It's very unlikely to show up, and since it's already marked for translation in other files, it will not add extra work on translators.

Show 33 quoted lines

>
> Signed-off-by: Raphaël Hertzog <hertzog@debian.org>
> ---
>  bisect.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/bisect.c b/bisect.c
> index a579b5088..8edc7a7a6 100644
> --- a/bisect.c
> +++ b/bisect.c
> @@ -658,8 +658,8 @@ static void exit_if_skipped_commits(struct commit_list *tried,
>         if (!tried)
>                 return;
>
> -       printf("There are only 'skip'ped commits left to test.\n"
> -              "The first %s commit could be any of:\n", term_bad);
> +       printf(_("There are only 'skip'ped commits left to test.\n"
> +                "The first %s commit could be any of:\n"), term_bad);
>
>         for ( ; tried; tried = tried->next)
>                 printf("%s\n", oid_to_hex(&tried->item->object.oid));
> @@ -984,7 +984,7 @@ int bisect_next_all(const char *prefix, int no_checkout)
>
>         if (!oidcmp(bisect_rev, current_bad_oid)) {
>                 exit_if_skipped_commits(tried, current_bad_oid);
> -               printf("%s is the first %s commit\n", oid_to_hex(bisect_rev),
> +               printf(_("%s is the first %s commit\n"), oid_to_hex(bisect_rev),
>                         term_bad);
>                 show_diff_tree(prefix, revs.commits->item);
>                 /* This means the bisection process succeeded. */
> --
> 2.18.0.rc2
>

-- 
Duy