Re: What's cooking in git.git (Sep 2018, #03; Fri, 14)
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Sep 16, 2018, 06:39 UTC
- Message-ID
- <CACsJy8DXT8rF_WYE3C0ak7E8_8j=kRS+Yhi1pZjKd5Rr4OsM_A@mail.gmail.com>
- In-Reply-To
- <xmqqy3c3agkr.fsf@gitster-ct.c.googlers.com>
On Fri, Sep 14, 2018 at 11:56 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> * jn/gc-auto (2018-07-17) 3 commits > - gc: do not return error for prior errors in daemonized mode > - gc: exit with status 128 on failure > - gc: improve handling of errors reading gc.log > > "gc --auto" ended up calling exit(-1) upon error, which has been > corrected to use exit(1). Also the error reporting behaviour when > daemonized has been updated to exit with zero status when stopping > due to a previously discovered error (which implies there is no > point running gc to improve the situation); we used to exit with > failure in such a case. > > What's the donness of this one? > cf. <20180717201348.GD26218@sigill.intra.peff.net>
This topic has stayed in 'pu' for a long time. I thought it was concluded that this was a good change? Jeff, Jonathan?
-- Duy