From: Duy Nguyen Date: Sun, 16 Sep 2018 06:39:03 GMT Subject: Re: What's cooking in git.git (Sep 2018, #03; Fri, 14) Message-ID: In-Reply-To: On Fri, Sep 14, 2018 at 11:56 PM Junio C Hamano wrote: > * jn/gc-auto (2018-07-17) 3 commits > - gc: do not return error for prior errors in daemonized mode > - gc: exit with status 128 on failure > - gc: improve handling of errors reading gc.log > > "gc --auto" ended up calling exit(-1) upon error, which has been > corrected to use exit(1). Also the error reporting behaviour when > daemonized has been updated to exit with zero status when stopping > due to a previously discovered error (which implies there is no > point running gc to improve the situation); we used to exit with > failure in such a case. > > What's the donness of this one? > cf. <20180717201348.GD26218@sigill.intra.peff.net> This topic has stayed in 'pu' for a long time. I thought it was concluded that this was a good change? Jeff, Jonathan? -- Duy