Re: What's cooking in git.git (Sep 2018, #03; Fri, 14)

From: Jeff King <peff@peff.net>
Date: Sep 17, 2018, 02:39 UTC
Message-ID: <20180917023912.GC22024@sigill.intra.peff.net>
In-Reply-To: <CACsJy8DXT8rF_WYE3C0ak7E8_8j=kRS+Yhi1pZjKd5Rr4OsM_A@mail.gmail.com>

On Sun, Sep 16, 2018 at 08:39:03AM +0200, Duy Nguyen wrote:

Show 18 quoted lines

> On Fri, Sep 14, 2018 at 11:56 PM Junio C Hamano <gitster@pobox.com> wrote:
> > * jn/gc-auto (2018-07-17) 3 commits
> >  - gc: do not return error for prior errors in daemonized mode
> >  - gc: exit with status 128 on failure
> >  - gc: improve handling of errors reading gc.log
> >
> >  "gc --auto" ended up calling exit(-1) upon error, which has been
> >  corrected to use exit(1).  Also the error reporting behaviour when
> >  daemonized has been updated to exit with zero status when stopping
> >  due to a previously discovered error (which implies there is no
> >  point running gc to improve the situation); we used to exit with
> >  failure in such a case.
> >
> >  What's the donness of this one?
> >  cf. <20180717201348.GD26218@sigill.intra.peff.net>
> 
> This topic has stayed in 'pu' for a long time. I thought it was
> concluded that this was a good change? Jeff, Jonathan?

I read over the thread again. I don't think I actually have any complaints about the patches as-is. There was some discussion from Junio and Ævar about the third one. I don't have a strong opinion. My experience has been that "gc --auto" is garbage anyway on the server side, but I think Ævar's experience is that it's reasonable for small to medium sites (which seems plausible to me).

The message-id quoted there is my "this looks good". I mentioned a few possible nits, but I think it would be OK with or without them addressed.

-Peff