Re: regression in multi-threaded git-pack-index

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 16, 2013, 12:38 UTC
Message-ID: <CACsJy8D9zwwij9DDrug_tvp2_zrXG7RGcZBbKzpHu1T5iQdxZg@mail.gmail.com>
In-Reply-To: <20130316114118.GA1940@sigill.intra.peff.net>

On Sat, Mar 16, 2013 at 6:41 PM, Jeff King <peff@peff.net> wrote:

Show 5 quoted lines

> On Fri, Mar 15, 2013 at 03:42:40PM -0700, Stefan Zager wrote:
>
>> We have uncovered a regression in this commit:
>>
>> b8a2486f1524947f232f657e9f2ebf44e3e7a243

What version did you test? We used to have problems with multithreaded index-pack on cywgin because its pread implementation is not thread-safe, see c0f8654 (index-pack: Disable threading on cygwin - 2012-06-26). Not sure if we fall into the same path on Mac, or this is something else..

Show 5 quoted lines

>>
>> The symptom is that 'git fetch' dies with:
>>
>> error: index-pack died of signal 10
>> fatal: index-pack failed

I guess it won't help much, but what if you enable coredump and get a stack trace from it?

Show 5 quoted lines

>>
>> I have only been able to reproduce it on a Mac thus far; will try
>> ubuntu next.  We can make it go away by running:
>>
>> git config pack.threads 1

-- 
Duy