Re: [PATCH v2] index-pack: always zero-initialize object_entry list

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 19, 2013, 17:13 UTC
Message-ID: <7vboafjot5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87ehfb2w4q.fsf@pctrast.inf.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

Show 12 quoted lines

> It apparently relates to the use of .idx.offset to compute the "next"
> offset, cf. append_obj_to_pack():
>
> 	struct object_entry *obj = &objects[nr_objects++];
>    ...
> 	obj[1].idx.offset = obj[0].idx.offset + n;
> 	obj[1].idx.offset += write_compressed(f, buf, size);
>
> So you trashed the offset of the first object after all the objects that
> are actually *in* the patch.
>
> And with that: ACK.

Ahh, I also was scratching my head about that +1 thing. After all, the +1 in the argument to xrealloc() was already a clue.

Thanks both for digging to the bottom of this one.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.