Re: [PATCH] index-pack: always zero-initialize object_entry list

From: Jeff King <peff@peff.net>
Date: Mar 19, 2013, 15:52 UTC
Message-ID: <20130319155244.GA16532@sigill.intra.peff.net>
In-Reply-To: <20130319154353.GA10010@sigill.intra.peff.net>

On Tue, Mar 19, 2013 at 11:43:53AM -0400, Jeff King wrote:

Show 16 quoted lines

> On Tue, Mar 19, 2013 at 04:33:42PM +0100, Thomas Rast wrote:
> 
> > Jeff King <peff@peff.net> writes:
> > 
> > > Commit 38a4556 (index-pack: start learning to emulate
> > > "verify-pack -v", 2011-06-03) added a "delta_depth" counter
> > > to each "struct object_entry". Initially, all object entries
> > > have their depth set to 0; in resolve_delta, we then set the
> > > depth of each delta to "base + 1". Base entries never have
> > > their depth touched, and remain at 0.
> > 
> > This patch causes index-pack to fail on the pack that triggered the
> > whole discussion.  More in a minute in another side thread, but
> > meanwhile: NAK until we understand what is really going on here.
> 
> Odd; that's what I was testing with, and it worked fine.

Ah, interesting. I built the fix on top of d1a0ed1, the first commit that shows the problem. And it works fine there. But when it is forward-ported to the current master, it breaks as you saw.

More bisection fun.

-Peff