Re: [PATCH] commit-tree: utilize parse-options api

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 28, 2019, 07:26 UTC
Message-ID: <CACsJy8D99BYRaWR+95VzM1gyhENje4N=HBNLJ=AA-op+y4yu2A@mail.gmail.com>
In-Reply-To: <CAETBDP5pfuNP4JQDaxN613sthRziJT7CZd=tjhWLpMSME9JjOQ@mail.gmail.com>

On Wed, Feb 27, 2019 at 10:24 PM Brandon Richardson <brandon1024.br@gmail.com> wrote:

Show 11 quoted lines

> > > +static int parse_file_arg_callback(const struct option *opt,
> > > +               const char *arg, int unset)
> >
> > I would suggest you do the same for -F, i.e. collect a string list of
> > paths then do the heavy lifting afterwards _IF_ we don't support
> > mixing -m and -F. If we do, then we have to handle both in callbacks
> > to make sure we compose the message correctly.
>
> I opted to use callbacks here to allow mixing -m and -F so that messages
> are composed correctly, as you mentioned. I did so in an attempt to match
> the existing functionality of commit-tree.

Fair enough. Probably safest to do that anyway.

If you feel like doing some improvements, maybe mention this behavior in git-commit-tree.txt too. It does say -m can be used multiple times, but nothing explicit about -F (and I wonder if -F also does the "becomes its own paragraph" like -m). Also mixing -m and -F technically could be inferred from the synopsis line, but it's just easier to read an plain English sentence.

-- 
Duy