Re: [PATCH] commit-tree: utilize parse-options api

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 27, 2019, 11:13 UTC
Message-ID: <CACsJy8BhEWRcEKRKpcBiZwewxYYoK0jipMZo9PeWAPCgDt1aNg@mail.gmail.com>
In-Reply-To: <CAETBDP7AyYKE2gQY-HbP+LBhYwvf1QXt0-JaEQwnVyr=PjrKMw@mail.gmail.com>

On Wed, Feb 27, 2019 at 6:43 AM Brandon Richardson <brandon1024.br@gmail.com> wrote:

Show 18 quoted lines

>
> Hi Andrei,
>
> > > would attempt to translate the option as a tree oid.It was also
> >
> > Missing space after period.
>
> Oops, thanks for pointing that out.
>
> >
> > > +             { OPTION_CALLBACK, 'p', NULL, &parents, "parent",
> > > +               N_("id of a parent commit object"), PARSE_OPT_NONEG,
> >
> > Comparing to other similar places, a single tab should be used to
> > align "N_" instead of two spaces.
>
> I've seen a mix of both conventions scattered around, and wasn't sure which
> to stick to. I'll switch to that.

I think we sometimes use spaces for fine alignment (search "tabs and spaces" in CodingGuidelines). It's really up to you and Andrei which style is preferred ;-)

-- 
Duy