git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] unpack-trees: do not abort when overwriting an existing file with the same content

From
Duy Nguyen <pclouds@gmail.com>
Date
Jan 22, 2013, 01:55 UTC
Message-ID
<CACsJy8CwkKyCLefrghVbq74FmeP7bPZAML-P=9s5PoPuNyT2Yg@mail.gmail.com>
In-Reply-To
<7vwqv6c7oe.fsf@alter.siamese.dyndns.org>
On Tue, Jan 22, 2013 at 8:45 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 25 quoted lines
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> On Tue, Jan 22, 2013 at 6:15 AM, Jeff King <peff@peff.net> wrote:
>>> Can you elaborate on when this code is triggered?
>>>
>>> In the general case, shouldn't we already know the sha1 of what's on
>>> disk in the index, and be able to just compare the hashes? And if we
>>> don't, because the entry is start-dirty, should we be updating it
>>> (possibly earlier, so we do not even get into the "need to write" code
>>> path) instead of doing this ad-hoc byte comparison?
>
> If the index knows what is in the working tree, I think I agree.
>
>>> Confused...
>>
>> git reset HEAD~10
>> # blah that was a mistake, undo it
>> git checkout HEAD@{1}
>>
>> I hit it a few times, probably not with the exact recipe above though.
>
> I've seen myself doing "git reset HEAD~10" by mistake (I wanted "--hard"),
> but the recovery is to do "git reset --hard @{1}" and then come back
> with "git reset --hard HEAD~10", so it hasn't been a real problem
> for me.
Except when you already make some changes elsewhere and you don't want --hard.
-- 
Duy
Previous: Junio C HamanoNext: Jeff King
Message 8 of 9 in “unpack-trees: do not abort when overwriting an existing file with the same content”
  1. unpack-trees: do not abort when overwriting an existing file with the same contentNguyễn Thái Ngọc Duy, Jan 19, 2013
  2. Junio C HamanoJan 20, 2013
  3. Duy NguyenJan 21, 2013
  4. unpack-trees: do not abort when overwriting an existing file with the same contentNguyễn Thái Ngọc Duy, Jan 21, 2013
  5. Jeff KingJan 21, 2013
  6. Duy NguyenJan 22, 2013
  7. Junio C HamanoJan 22, 2013
  8. Duy NguyenJan 22, 2013
  9. Jeff KingJan 22, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.