git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] unpack-trees: do not abort when overwriting an existing file with the same content

From
Jeff King <peff@peff.net>
Date
Jan 21, 2013, 23:15 UTC
Message-ID
<20130121231515.GD17156@sigill.intra.peff.net>
In-Reply-To
<1358768433-26096-1-git-send-email-pclouds@gmail.com>
On Mon, Jan 21, 2013 at 06:40:33PM +0700, Nguyen Thai Ngoc Duy wrote:
Show 27 quoted lines
> +	/*
> +	 * If it has the same content that we are going to overwrite,
> +	 * there's no point in complaining. We still overwrite it in
> +	 * the end though.
> +	 */
> +	if (ce &&
> +	    S_ISREG(st->st_mode) && S_ISREG(ce->ce_mode) &&
> +	    (!trust_executable_bit ||
> +	     (0100 & (ce->ce_mode ^ st->st_mode)) == 0) &&
> +	    st->st_size < SAME_CONTENT_SIZE_LIMIT &&
> +	    sha1_object_info(ce->sha1, &ce_size) == OBJ_BLOB &&
> +	    ce_size == st->st_size) {
> +		void *buffer = NULL;
> +		unsigned long size;
> +		enum object_type type;
> +		struct strbuf sb = STRBUF_INIT;
> +		int matched =
> +			strbuf_read_file(&sb, ce->name, ce_size) == ce_size &&
> +			(buffer = read_sha1_file(ce->sha1, &type, &size)) != NULL &&
> +			type == OBJ_BLOB &&
> +			size == ce_size &&
> +			!memcmp(buffer, sb.buf, size);
> +		free(buffer);
> +		strbuf_release(&sb);
> +		if (matched)
> +			return 0;
> +	}
Can you elaborate on when this code is triggered?

In the general case, shouldn't we already know the sha1 of what's on disk in the index, and be able to just compare the hashes? And if we don't, because the entry is start-dirty, should we be updating it (possibly earlier, so we do not even get into the "need to write" code path) instead of doing this ad-hoc byte comparison?

Confused...
-Peff
Previous: Nguyễn Thái Ngọc DuyNext: Duy Nguyen
Message 5 of 9 in “unpack-trees: do not abort when overwriting an existing file with the same content”
  1. unpack-trees: do not abort when overwriting an existing file with the same contentNguyễn Thái Ngọc Duy, Jan 19, 2013
  2. Junio C HamanoJan 20, 2013
  3. Duy NguyenJan 21, 2013
  4. unpack-trees: do not abort when overwriting an existing file with the same contentNguyễn Thái Ngọc Duy, Jan 21, 2013
  5. Jeff KingJan 21, 2013
  6. Duy NguyenJan 22, 2013
  7. Junio C HamanoJan 22, 2013
  8. Duy NguyenJan 22, 2013
  9. Jeff KingJan 22, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.