Re: [PATCH] unpack-trees: do not abort when overwriting an existing file with the same content

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 21, 2013, 01:35 UTC
Message-ID: <CACsJy8C-vRVsC5uj8xqucwMBZ2TEtwSF-58xM2oTSp6RtNAWMg@mail.gmail.com>
In-Reply-To: <7va9s3n1my.fsf@alter.siamese.dyndns.org>

On Mon, Jan 21, 2013 at 1:35 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> +     /*
>> +      * If it has the same content that we are going to write down,
>
> write down???

hmm.. "overwrite" then.

Show 6 quoted lines

>> +      * there's no point in complaining. We still overwrite it in the
>> +      * end though. Permission is not checked so it may be lost.
>> +      */
>
> That is a regression, isn't it?  Is it too cumbersome to avoid
> losing the permission bits by stopping in that case?

I'm not sure how to deal with this case. (Lack of) Executable bit can be easily restored (unlike file content) if we give the user the list of changed files. On the other hand, not everybody runs git with a huge scrollback buffer and warnings can be lost. I guess abort is a safe choice.

-- 
Duy