Re: [PATCH 9/9] clone: run check_everything_connected

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 26, 2013, 00:53 UTC
Message-ID: <CACsJy8CbBeuHmkEJs4FqGJs_kqEcjKi7RJkp9eNorxJAqgiCrg@mail.gmail.com>
In-Reply-To: <20130325202627.GI16019@sigill.intra.peff.net>

On Tue, Mar 26, 2013 at 3:26 AM, Jeff King <peff@peff.net> wrote:

Show 14 quoted lines

>  static void update_remote_refs(const struct ref *refs,
>                                const struct ref *mapped_refs,
>                                const struct ref *remote_head_points_at,
>                                const char *branch_top,
>                                const char *msg)
>  {
> +       const struct ref *rm = mapped_refs;
> +
> +       if (check_everything_connected(iterate_ref_map, 0, &rm))
> +               die(_("remote did not send all necessary objects"));
> +
>         if (refs) {
>                 write_remote_refs(mapped_refs);
>                 if (option_single_branch)

Maybe move this after checkout, so that I can switch terminal and start working while it's verifying? And maybe an option not to check_everything_connected, instead print a big fat warning telling the user to fsck later?

-- 
Duy