Re: propagating repo corruption across clone
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Mar 24, 2013, 19:01 UTC
- Message-ID
- <CACBZZX6czzJRF9TEsc8c+=LND6SxaVvrZdbcZ+TfUZTWQOpW0Q@mail.gmail.com>
- In-Reply-To
- <20130324183133.GA11200@sigill.intra.peff.net>
On Sun, Mar 24, 2013 at 7:31 PM, Jeff King <peff@peff.net> wrote:
> > I don't have details on the KDE corruption, or why it wasn't detected > (if it was one of the cases I mentioned above, or a more subtle issue).
One thing worth mentioning is this part of the article:
"Originally, mirrored clones were in fact not used, but non-mirrored clones on the anongits come with their own set of issues, and are more prone to getting stopped up by legitimate, authenticated force pushes, ref deletions, and so on – and if we set the refspec such that those are allowed through silently, we don’t gain much. "
So the only reason they were even using --mirror was because they were running into those problems with fetching.
So aside from the problems with --mirror I think we should have something that updates your local refs to be exactly like they are on the other end, i.e. deletes some, non-fast-forwards others etc. (obviously behind several --force options and so on). But such an option *wouldn't* accept corrupted objects.
That would give KDE and other parties a safe way to do exact repo mirroring like this, wouldn't protect them from someone maliciously deleting all the refs in all the repos, but would prevent FS corruption from propagating.