git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 15/16] index-helper: optionally automatically run

From
Duy Nguyen <pclouds@gmail.com>
Date
Apr 17, 2016, 05:19 UTC
Message-ID
<CACsJy8C8un8AAwr5OWX6b8+ync=hqe3JLb=zNMN947oDLmZo4w@mail.gmail.com>
In-Reply-To
<1460507589-25525-16-git-send-email-dturner@twopensource.com>
On Wed, Apr 13, 2016 at 7:33 AM, David Turner <dturner@twopensource.com> wrote:
Show 10 quoted lines
> @@ -536,8 +567,10 @@ static void handle_builtin(int argc, const char **argv)
>         }
>
>         builtin = get_builtin(cmd);
> -       if (builtin)
> +       if (builtin) {
> +               maybe_run_index_helper(builtin);
>                 exit(run_builtin(builtin, argc, argv));
> +       }
>  }

Isn't it too early to start index-helper here? Unrelated commands like git-log are affected. And config handling this early could be tricky. A better place may be in the socket connection code. When we fail to connect, we can check config key and run index-helper then.

-- 
Duy
Previous: David TurnerNext: David Turner
Message 37 of 39 in “index-helper, watchman”
  1. 00/16 index-helper, watchmanDavid Turner, Apr 13, 2016
  2. 01/16 read-cache.c: fix constness of verify_hdr()David Turner, Apr 13, 2016
  3. 02/16 read-cache: allow to keep mmap'd memory after readingDavid Turner, Apr 13, 2016
  4. 03/16 index-helper: new daemon for caching index and related stuffDavid Turner, Apr 13, 2016
  5. Duy NguyenApr 13, 2016
  6. David TurnerApr 13, 2016
  7. Duy NguyenApr 14, 2016
  8. David TurnerApr 15, 2016
  9. Duy NguyenApr 15, 2016
  10. David TurnerApr 15, 2016
  11. Duy NguyenApr 16, 2016
  12. Ramsay JonesApr 13, 2016
  13. David TurnerApr 13, 2016
  14. Junio C HamanoApr 14, 2016
  15. David TurnerApr 14, 2016
  16. Duy NguyenApr 15, 2016
  17. Stefan BellerApr 16, 2016
  18. David TurnerApr 19, 2016
  19. David TurnerApr 19, 2016
  20. 04/16 index-helper: add --strictDavid Turner, Apr 13, 2016
  21. 05/16 daemonize(): set a flag before exiting the main processDavid Turner, Apr 13, 2016
  22. 06/16 index-helper: add --detachDavid Turner, Apr 13, 2016
  23. 07/16 read-cache: add watchman 'WAMA' extensionDavid Turner, Apr 13, 2016
  24. 08/16 Add watchman support to reduce index refresh costDavid Turner, Apr 13, 2016
  25. Duy NguyenApr 17, 2016
  26. 09/16 index-helper: use watchman to avoid refreshing index with lstat()David Turner, Apr 13, 2016
  27. Stefan BellerApr 16, 2016
  28. David TurnerApr 19, 2016
  29. 10/16 update-index: enable/disable watchman supportDavid Turner, Apr 13, 2016
  30. 11/16 unpack-trees: preserve index extensionsDavid Turner, Apr 13, 2016
  31. 12/16 index-helper: kill modeDavid Turner, Apr 13, 2016
  32. Ævar Arnfjörð BjarmasonApr 16, 2016
  33. David TurnerApr 19, 2016
  34. 13/16 index-helper: don't run if already runningDavid Turner, Apr 13, 2016
  35. 14/16 index-helper: autorun modeDavid Turner, Apr 13, 2016
  36. 15/16 index-helper: optionally automatically runDavid Turner, Apr 13, 2016
  37. Duy NguyenApr 17, 2016
  38. David TurnerApr 19, 2016
  39. 16/16 read-cache: config for waiting for index-helperDavid Turner, Apr 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.