Re: [PATCH v4 15/16] index-helper: optionally automatically run

From: David Turner <dturner@twopensource.com>
Date: Apr 19, 2016, 22:31 UTC
Message-ID: <1461105079.5540.131.camel@twopensource.com>
In-Reply-To: <CACsJy8C8un8AAwr5OWX6b8+ync=hqe3JLb=zNMN947oDLmZo4w@mail.gmail.com>

On Sun, 2016-04-17 at 12:19 +0700, Duy Nguyen wrote:

Show 19 quoted lines

> On Wed, Apr 13, 2016 at 7:33 AM, David Turner <
> dturner@twopensource.com> wrote:
> > @@ -536,8 +567,10 @@ static void handle_builtin(int argc, const
> > char **argv)
> >         }
> > 
> >         builtin = get_builtin(cmd);
> > -       if (builtin)
> > +       if (builtin) {
> > +               maybe_run_index_helper(builtin);
> >                 exit(run_builtin(builtin, argc, argv));
> > +       }
> >  }
> 
> Isn't it too early to start index-helper here? Unrelated commands
> like
> git-log are affected. And config handling this early could be tricky.
> A better place may be in the socket connection code. When we fail to
> connect, we can check config key and run index-helper then.

Will move.