[PATCH v4 06/16] index-helper: add --detach
- From
David Turner <dturner@twopensource.com>
- Date
- Apr 13, 2016, 00:32 UTC
- Message-ID
- <1460507589-25525-7-git-send-email-dturner@twopensource.com>
- In-Reply-To
- <1460507589-25525-1-git-send-email-dturner@twopensource.com>
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
We detach after creating and opening the socket, because otherwise we might return control to the shell before index-helper is ready to accept commands. This might lead to flaky tests.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: David Turner <dturner@twopensource.com> --- Documentation/git-index-helper.txt | 3 +++ index-helper.c | 11 +++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-index-helper.txt b/Documentation/git-index-helper.txt index 2382ba8..305ff35 100644 --- a/Documentation/git-index-helper.txt +++ b/Documentation/git-index-helper.txt @@ -31,6 +31,9 @@ OPTIONS for reading an index, but because it will happen in the background, it's not noticable. `--strict` is enabled by default. +--detach:: + Detach from the shell. + NOTES ----- diff --git a/index-helper.c b/index-helper.c index 9a4278f..83bfef5 100644 --- a/index-helper.c +++ b/index-helper.c @@ -16,7 +16,7 @@ struct shm { static struct shm shm_index; static struct shm shm_base_index; -static int to_verify = 1; +static int daemonized, to_verify = 1; static char *my_tmp_dir; @@ -103,6 +103,8 @@ static void cleanup_shm(void) static void cleanup(void) { + if (daemonized) + return; unlink(git_path("index-helper.path")); cleanup_shm(); } @@ -354,7 +356,7 @@ static const char * const usage_text[] = { int main(int argc, char **argv) { const char *prefix; - int idle_in_seconds = 600; + int idle_in_seconds = 600, detach = 0; int fd; struct strbuf socket_path = STRBUF_INIT; struct option options[] = { @@ -362,6 +364,7 @@ int main(int argc, char **argv) N_("exit if not used after some seconds")), OPT_BOOL(0, "strict", &to_verify, "verify shared memory after creating"), + OPT_BOOL(0, "detach", &detach, "detach the process"), OPT_END() }; @@ -396,6 +399,10 @@ int main(int argc, char **argv) die(_("failed to delete old index-helper.path")); if (symlink(get_my_tmp_dir(), git_path("index-helper.path"))) die(_("failed to symlink socket path into index-helper.path")); + + if (detach && daemonize(&daemonized)) + die_errno(_("unable to detach")); + loop(fd, idle_in_seconds); return 0;
-- 2.4.2.767.g62658d5-twtrsrc