Re: [PATCH 01/16] Modify cache_header to prepare for other index formats

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Aug 2, 2012, 12:15 UTC
Message-ID: <CACsJy8C4D=nmcLmX_mahrx9TMCjzzqWdEsGU9W=gmhJVAqdk4A@mail.gmail.com>
In-Reply-To: <1343905326-23790-2-git-send-email-t.gummerer@gmail.com>

On Thu, Aug 2, 2012 at 6:01 PM, Thomas Gummerer <t.gummerer@gmail.com> wrote:

Show 18 quoted lines

> diff --git a/cache.h b/cache.h
> index 6e9a243..d4028ef 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -99,9 +99,12 @@ unsigned long git_deflate_bound(git_zstream *, unsigned long);
>   */
>
>  #define CACHE_SIGNATURE 0x44495243     /* "DIRC" */
> -struct cache_header {
> +struct cache_version_header {
>         unsigned int hdr_signature;
>         unsigned int hdr_version;
> +};
> +
> +struct cache_header_v2 {
>         unsigned int hdr_entries;
>  };
>

These structs should probably be moved to read-cache.c. We can redeclare cache_version_header again in test-index-version.c (it does not look too bad to me).

-- 
Duy