Re: [RFC/PATCH] config: add core.trustmtime

From: Duy Nguyen <pclouds@gmail.com>
Date: Nov 30, 2015, 19:12 UTC
Message-ID: <CACsJy8BZo4hFz+mQKNxrmPQaGforvguFmjL90g=Hf698okFs2A@mail.gmail.com>
In-Reply-To: <xmqq610j8fzt.fsf@gitster.mtv.corp.google.com>

On Mon, Nov 30, 2015 at 8:05 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Maybe I'm missing some really common breakage with st_mtime on some
>> system, but having a feature the user explicitly enables turn itself
>> off and doing FS-testing that takes 10 seconds when it's enabled seems
>> like the wrong default to me.
>>
>> We don't do it with core.fileMode, core.ignorecase or core.trustctime
>> or core.symlinks. Do we really need to be treating this differently?
>
> I share the exact thought.  I was looking the other way when
> untracked-cache was done originally ;-), and I would also want to
> know the answers to the above questions.

OK I was just paranoid (and having to look at filesystem source code to determine if it supported this didn't help either). So I guess that means we can make the test a separate option, only invoked by the user, then.

-- 
Duy