git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] config: add core.trustmtime

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Nov 27, 2015, 01:35 UTC
Message-ID
<CACBZZX4jJ_b-5sbor6YibXGASeOa0gx8nEBiv8=54yoHfWL8Fw@mail.gmail.com>
In-Reply-To
<CACsJy8CNRbvsDY+ucFZGcO4+tE9Ud_QNr1k4D=+utawSCrc+Sg@mail.gmail.com>
On Thu, Nov 26, 2015 at 6:53 PM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 9 quoted lines
> On Thu, Nov 26, 2015 at 6:21 AM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> I am wondering why you didn't make it by default run the mtime checks
>> when a kernel change is detected. Maybe that would be better than
>> disabling itself.
>
> It takes about 10 seconds to go through the mtime check. Imagine you
> have to wait 10s for some random "git status".. Plus I didn't want to
> do anything fancy.

I browsed through the commits that added the --untracked-cache and tried to find the original mailing list discussion, but I couldn't find the reason for why the default interface for enabling it is doing these exhaustive tests.

Maybe I'm missing some really common breakage with st_mtime on some system, but having a feature the user explicitly enables turn itself off and doing FS-testing that takes 10 seconds when it's enabled seems like the wrong default to me.

We don't do it with core.fileMode, core.ignorecase or core.trustctime or core.symlinks. Do we really need to be treating this differently?

If that's a "no" then the default interface to this could be much simpler. Rather than being a change you apply to .git/index (going away if you nuke it etc.) it could just be a config option like the rest.

Previous: Duy NguyenNext: Junio C Hamano
Message 6 of 13 in “config: add core.trustmtime”
  1. config: add core.trustmtimeChristian Couder, Nov 25, 2015
  2. Ævar Arnfjörð BjarmasonNov 25, 2015
  3. Duy NguyenNov 25, 2015
  4. Christian CouderNov 26, 2015
  5. Duy NguyenNov 26, 2015
  6. Ævar Arnfjörð BjarmasonNov 27, 2015
  7. Junio C HamanoNov 30, 2015
  8. Duy NguyenNov 30, 2015
  9. Torsten BögershausenDec 1, 2015
  10. Duy NguyenDec 2, 2015
  11. Christian CouderDec 7, 2015
  12. Johannes SchindelinNov 25, 2015
  13. Christian CouderNov 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.