Re: [PATCH v2 1/4] delete_ref: accept a reflog message argument

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 23, 2017, 09:33 UTC
Message-ID: <CACsJy8BJgL1i85nZ9CpAXCKaG+PQQkjRKLFPWzbsMF8WN8TEjQ@mail.gmail.com>
In-Reply-To: <20170221011035.847-2-kyle@kyleam.com>

On Tue, Feb 21, 2017 at 8:10 AM, Kyle Meyer <kyle@kyleam.com> wrote:

Show 12 quoted lines

> diff --git a/refs.h b/refs.h
> index 9fbff90e7..5880886a7 100644
> --- a/refs.h
> +++ b/refs.h
> @@ -276,8 +276,8 @@ int reflog_exists(const char *refname);
>   * exists, regardless of its old value. It is an error for old_sha1 to
>   * be NULL_SHA1. flags is passed through to ref_transaction_delete().
>   */
> -int delete_ref(const char *refname, const unsigned char *old_sha1,
> -              unsigned int flags);
> +int delete_ref(const char *msg, const char *refname,
> +              const unsigned char *old_sha1, unsigned int flags);

Is it just me who thinks it's weird that msg comes in front here? The key identity, refname, should be the first argument imo. You'll probably want to update the comment block above if msg can be NULL. We have _very_ good documentation in this file, let's keep it uptodate.

-- 
Duy