git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git stash doesn't honor --work-tree or GIT_WORK_TREE

From
Duy Nguyen <pclouds@gmail.com>
Date
Dec 1, 2013, 11:50 UTC
Message-ID
<CACsJy8BFqqy8T1zwZd7Ly1-sAKGoxh0YfhFBgX6fBMTt_b5Dbw@mail.gmail.com>
In-Reply-To
<874n6sddu7.fsf@thomasrast.ch>
On Sun, Dec 1, 2013 at 6:12 PM, Thomas Rast <tr@thomasrast.ch> wrote:
Show 10 quoted lines
> Øystein Walle <oystwa@gmail.com> writes:
>> The problem seems to be that git rev-parse --is-inside-work-tree does
>> not honor these. In fact it doesn't even honor --git-dir or --work-tree.
>> Judging by the name this may be intentional.
>
> Thanks for investigating this.
>
> Duy, you are the expert on the worktree detection logic.  Do you know if
> there is a reason for --is-inside-work-tree to not honor the
> GIT_WORK_TREE / GIT_DIR overrides?

It should. At the beginning of cmd_rev_parse(), setup_git_directory() is called, which will check and follow all GIT_* or their command line equivalent. I'll look into this some time later.

-- 
Duy
Previous: Thomas RastNext: Thomas Rast
Message 4 of 7 in “git stash doesn't honor --work-tree or GIT_WORK_TREE”
  1. Aaron BrooksNov 30, 2013
  2. Øystein WalleNov 30, 2013
  3. Thomas RastDec 1, 2013
  4. Duy NguyenDec 1, 2013
  5. Thomas RastDec 1, 2013
  6. Junio C HamanoDec 2, 2013
  7. Øystein WalleDec 1, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.