Re: git stash doesn't honor --work-tree or GIT_WORK_TREE

From: Thomas Rast <tr@thomasrast.ch>
Date: Dec 1, 2013, 11:12 UTC
Message-ID: <874n6sddu7.fsf@thomasrast.ch>
In-Reply-To: <loom.20131130T221443-682@post.gmane.org>

Øystein Walle <oystwa@gmail.com> writes:

> Aaron Brooks <aaron <at> brooks1.net> writes:
>
>> Unlike other commands, git stash doesn't work outside of the worktree,
>> even when --work-tree is specified:

[...]

Show 8 quoted lines

> The environment variables are properly exported. I verified this by
> adding 'echo $GIT_WORK_TREE; echo $GIT_DIR' at the top of git-stash.sh.
> So these should propagate to "child gits" just fine, and so it shouldn't
> be necessary to test them explicitly.
>
> The problem seems to be that git rev-parse --is-inside-work-tree does
> not honor these. In fact it doesn't even honor --git-dir or --work-tree.
> Judging by the name this may be intentional.

Thanks for investigating this.

Duy, you are the expert on the worktree detection logic. Do you know if there is a reason for --is-inside-work-tree to not honor the GIT_WORK_TREE / GIT_DIR overrides?

-- 
Thomas Rast
tr@thomasrast.ch