From: Duy Nguyen <pclouds@gmail.com>
Date: Sun, 01 Dec 2013 11:50:14 GMT
Subject: Re: git stash doesn't honor --work-tree or GIT_WORK_TREE
Message-ID: <CACsJy8BFqqy8T1zwZd7Ly1-sAKGoxh0YfhFBgX6fBMTt_b5Dbw@mail.gmail.com>
In-Reply-To: <874n6sddu7.fsf@thomasrast.ch>

On Sun, Dec 1, 2013 at 6:12 PM, Thomas Rast <tr@thomasrast.ch> wrote:
> Øystein Walle <oystwa@gmail.com> writes:
>> The problem seems to be that git rev-parse --is-inside-work-tree does
>> not honor these. In fact it doesn't even honor --git-dir or --work-tree.
>> Judging by the name this may be intentional.
>
> Thanks for investigating this.
>
> Duy, you are the expert on the worktree detection logic.  Do you know if
> there is a reason for --is-inside-work-tree to not honor the
> GIT_WORK_TREE / GIT_DIR overrides?

It should. At the beginning of cmd_rev_parse(), setup_git_directory()
is called, which will check and follow all GIT_* or their command line
equivalent. I'll look into this some time later.
-- 
Duy