Re: [PATCH i18n 09/11] i18n: apply: update say_patch_name to give translators complete sentence

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Apr 23, 2012, 11:33 UTC
Message-ID: <CACsJy8AQtsmC65SXXjR_=e5T+LF=WYHPFMvK5EUcV_ZYKQuOag@mail.gmail.com>
In-Reply-To: <4F9434F1.9000900@in.waw.pl>

On Sun, Apr 22, 2012 at 11:42 PM, Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> wrote:

Show 13 quoted lines

> On 04/16/2012 02:50 PM, Nguyễn Thái Ngọc Duy wrote:
>> @@ -3551,8 +3555,9 @@ static int write_out_one_reject(struct patch *patch)
>>               die(_("internal error"));
>>
>>       /* Say this even without --verbose */
>> -     say_patch_name(stderr, "Applying patch ", patch, " with");
>> -     fprintf(stderr, " %d rejects...\n", cnt);
>> +     strbuf_addf(&sb, _("Applying patch %%s with %d rejects..."), cnt);
> Shouldn't this part be:
>        strbuf_addf(&sb, Q_("Applying patch %%s with one reject...",
>                            "Applying patch %%s with %d rejects...",
>                            cnt), cnt);
> ?

Yes. Thanks for catching.

-- 
Duy