Re: git show doesn't work on file names with square brackets

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 8, 2016, 05:06 UTC
Message-ID: <CACsJy8AMEgk8UXF==VmvLXsL4R67u0+U4MiUGPtO6HX0Y30oXg@mail.gmail.com>
In-Reply-To: <32B9BD70-F06C-49C4-B672-24173E69B99F@jetbrains.com>

On Sun, Feb 7, 2016 at 10:11 PM, Kirill Likhodedov <kirill.likhodedov@jetbrains.com> wrote:

Show 14 quoted lines

> Hi Duy,
>
>> It's from 28fcc0b (pathspec: avoid the need of "--" when wildcard is
>> used - 2015-05-02)
>
> v2.5.0 is the first release which contains 28fcc0b.
> I can confirm that older versions of Git work correctly without “--“:
>
> # /opt/local/bin/git version
> git version 1.7.1.1
> # /opt/local/bin/git show HEAD:bra[ckets].txt
> asd
>
> Looks like a regression?

No it's a deliberate trade-off. With that change, you can use wildcards in pathspec without "--" (e.g. "git log 'a*'" instead of "git log -- 'a*'"). And I still believe that happens a lot more often than this case. Putting "--" is _the_ way to avoid ambiguation when git fails to do it properly. Though in future we may make git smarter at solving ambiguation (e.g. it could do glob() to test if a wildcard pattern matches any path).

-- 
Duy