Re: git show doesn't work on file names with square brackets

From: Jeff King <peff@peff.net>
Date: Feb 8, 2016, 14:24 UTC
Message-ID: <20160208142439.GA8262@sigill.intra.peff.net>
In-Reply-To: <20160208141552.GC27054@sigill.intra.peff.net>

On Mon, Feb 08, 2016 at 09:15:52AM -0500, Jeff King wrote:

Show 6 quoted lines

> I wonder if we could fix this pretty simply, though, by skipping the
> "does it have a wildcard" check when we see a colon in the path. That is
> a good indication that we are using one of git's special rev syntaxes
> (either "tree:path", or ":path", or ":/search string". That breaks
> anybody who really wanted to look for "path:with:colons.*", but that
> seems a lot less likely to me.

Actually, I guess:

  :/foo

does have a meaning as a pathspec (though again, this is only about limiting the wildcard case, so I think that's OK). More worrisome would be:

  :(literal)[brackets]

which is almost certainly a pathspec.

So I guess I would revise my suggestion to: we could probably do a lot better (but not perfectly, of course) by guessing at basic syntactic components.

-Peff