Re: git show doesn't work on file names with square brackets

From: Jeff King <peff@peff.net>
Date: Feb 10, 2016, 21:12 UTC
Message-ID: <20160210211206.GA5755@sigill.intra.peff.net>
In-Reply-To: <xmqqpow4zcwd.fsf@gitster.mtv.corp.google.com>

On Wed, Feb 10, 2016 at 09:35:46AM -0800, Junio C Hamano wrote:

Show 5 quoted lines

> > IOW, something like this implements the "permissive" thing I wrote above
> > (i.e., be inclusive when seeing if something could plausibly be a
> > filename, but exclusive when complaining that it _could_ be one):
> 
> Yup, I think that is probably a better first step.

Thanks. And thank you for the discussion. I read your response last night and almost just said "OK, let's just scrap my patches, this isn't worth the trouble". But after reading it again this morning, I think it forced me to look at the problem in a new way. And while I did scrap my original patches here, I think the result is accomplishing the same thing in a much saner way.

Here's what I came up with.

  [1/3]: checkout: reorder check_filename conditional
  [2/3]: check_filename: tighten dwim-wildcard ambiguity
  [3/3]: get_sha1: don't die() on bogus search strings

The first is a minor preparatory cleanup, the second is the meat we've been discussing, and the third is a bonus, though it has some tradeoffs.

-Peff