git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/8] ls_colors.c: enable coloring on u+x files

From
Duy Nguyen <pclouds@gmail.com>
Date
Mar 21, 2014, 11:52 UTC
Message-ID
<CACsJy8A2TaGvS0S9P1hOBmqXPTQszKcVTjXDEPX0kTrdN17Xxg@mail.gmail.com>
In-Reply-To
<xmqq7g7ozs0u.fsf@gitster.dls.corp.google.com>
On Fri, Mar 21, 2014 at 12:41 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> Why even include cache.h for S_IXUSR?
>
> In the context of the patch I see S_ISGID mentioned and other S_*
> st_mode things are already in use in this function before this step,
> and presumably you are using them without problems, no?

My mistake. git-compat-util.h does include S_IXUSR. The original code was S_IXUGO that's in neither files.

-- 
Duy
Previous: Junio C HamanoNext: Nguyễn Thái Ngọc Duy
Message 11 of 79 in “git-ls”
  1. 0/8 git-lsNguyễn Thái Ngọc Duy, Mar 20, 2014
  2. 1/8 Import $LS_COLORS parsing code from coreutilsNguyễn Thái Ngọc Duy, Mar 20, 2014
  3. David TranMar 20, 2014
  4. Duy NguyenMar 21, 2014
  5. David TranMar 21, 2014
  6. 2/8 ls_colors.c: a bit of document on print_color_indicator inputNguyễn Thái Ngọc Duy, Mar 20, 2014
  7. 3/8 ls_colors.c: enable coloring on u+x filesNguyễn Thái Ngọc Duy, Mar 20, 2014
  8. Matthieu MoyMar 20, 2014
  9. Duy NguyenMar 20, 2014
  10. Junio C HamanoMar 20, 2014
  11. Duy NguyenMar 21, 2014
  12. 4/8 ls_colors.c: new color descriptorsNguyễn Thái Ngọc Duy, Mar 20, 2014
  13. 5/8 ls-files: add --color to highlight based on $LS_COLORSNguyễn Thái Ngọc Duy, Mar 20, 2014
  14. 6/8 ls-files: add --columnNguyễn Thái Ngọc Duy, Mar 20, 2014
  15. Matthieu MoyMar 25, 2014
  16. 7/8 ls-files: support --max-depthNguyễn Thái Ngọc Duy, Mar 20, 2014
  17. Matthieu MoyMar 25, 2014
  18. Duy NguyenMar 25, 2014
  19. Duy NguyenMar 27, 2014
  20. Matthieu MoyMar 28, 2014
  21. Duy NguyenMar 28, 2014
  22. Duy NguyenMar 28, 2014
  23. 8/8 Add git-ls, a user friendly version of ls-files and moreNguyễn Thái Ngọc Duy, Mar 20, 2014
  24. Matthieu MoyMar 20, 2014
  25. 00/17 git-lsNguyễn Thái Ngọc Duy, Mar 26, 2014
  26. 01/17 ls_colors.c: add $LS_COLORS parsing codeNguyễn Thái Ngọc Duy, Mar 26, 2014
  27. 02/17 ls_colors.c: parse color.ls.* from config fileNguyễn Thái Ngọc Duy, Mar 26, 2014
  28. 03/17 ls_colors.c: add function to color a file nameNguyễn Thái Ngọc Duy, Mar 26, 2014
  29. Eric SunshineMar 26, 2014
  30. 04/17 ls_colors.c: highlight submodules like directoriesNguyễn Thái Ngọc Duy, Mar 26, 2014
  31. 05/17 ls-files: buffer full item in strbuf before printingNguyễn Thái Ngọc Duy, Mar 26, 2014
  32. Eric SunshineMar 26, 2014
  33. Duy NguyenMar 26, 2014
  34. Eric SunshineMar 27, 2014
  35. 06/17 ls-files: add --color to highlight file namesNguyễn Thái Ngọc Duy, Mar 26, 2014
  36. Eric SunshineMar 26, 2014
  37. Duy NguyenMar 26, 2014
  38. Eric SunshineMar 28, 2014
  39. 07/17 ls-files: add --columnNguyễn Thái Ngọc Duy, Mar 26, 2014
  40. Eric SunshineMar 26, 2014
  41. 08/17 ls-files: support --max-depthNguyễn Thái Ngọc Duy, Mar 26, 2014
  42. Eric SunshineMar 26, 2014
  43. 09/17 ls-files: split main ls-files logic into ls_files() functionNguyễn Thái Ngọc Duy, Mar 26, 2014
  44. 10/17 Add git-ls, a user friendly version of ls-files and moreNguyễn Thái Ngọc Duy, Mar 26, 2014
  45. Eric SunshineMar 26, 2014
  46. 11/17 ls: -u does not imply showing stagesNguyễn Thái Ngọc Duy, Mar 26, 2014
  47. 12/17 ls: add -R/--recursive short for --max-depth=-1Nguyễn Thái Ngọc Duy, Mar 26, 2014
  48. 13/17 ls: add -1 short for --no-column in the spirit of GNU lsNguyễn Thái Ngọc Duy, Mar 26, 2014
  49. Eric SunshineMar 28, 2014
  50. 14/17 ls: add -t backNguyễn Thái Ngọc Duy, Mar 26, 2014
  51. 15/17 ls: sort output and remove duplicatesNguyễn Thái Ngọc Duy, Mar 26, 2014
  52. 16/17 ls: do not show duplicate cached entriesNguyễn Thái Ngọc Duy, Mar 26, 2014
  53. Eric SunshineMar 28, 2014
  54. ls-files: do not trust stat info if lstat() failsNguyễn Thái Ngọc Duy, Mar 28, 2014
  55. Junio C HamanoApr 2, 2014
  56. Duy NguyenApr 3, 2014
  57. Junio C HamanoApr 3, 2014
  58. Duy NguyenApr 5, 2014
  59. Junio C HamanoApr 7, 2014
  60. 17/17 ls: show directories as well as filesNguyễn Thái Ngọc Duy, Mar 26, 2014
  61. 00/18 git-lsNguyễn Thái Ngọc Duy, Mar 30, 2014
  62. 01/18 ls_colors.c: add $LS_COLORS parsing codeNguyễn Thái Ngọc Duy, Mar 30, 2014
  63. 02/18 ls_colors.c: parse color.ls.* from config fileNguyễn Thái Ngọc Duy, Mar 30, 2014
  64. 03/18 ls_colors.c: add a function to color a file nameNguyễn Thái Ngọc Duy, Mar 30, 2014
  65. 04/18 ls_colors.c: highlight submodules like directoriesNguyễn Thái Ngọc Duy, Mar 30, 2014
  66. 05/18 ls-files: buffer full item in strbuf before printingNguyễn Thái Ngọc Duy, Mar 30, 2014
  67. 06/18 ls-files: add --color to highlight file namesNguyễn Thái Ngọc Duy, Mar 30, 2014
  68. 07/18 ls-files: add --columnNguyễn Thái Ngọc Duy, Mar 30, 2014
  69. 08/18 ls-files: support --max-depthNguyễn Thái Ngọc Duy, Mar 30, 2014
  70. 09/18 Add git-list-files, a user friendly version of ls-files and moreNguyễn Thái Ngọc Duy, Mar 30, 2014
  71. 10/18 list-files: -u does not imply showing stagesNguyễn Thái Ngọc Duy, Mar 30, 2014
  72. 11/18 list-files: add -R/--recursive short for --max-depth=-1Nguyễn Thái Ngọc Duy, Mar 30, 2014
  73. 12/18 list-files: add -1 short for --no-columnNguyễn Thái Ngọc Duy, Mar 30, 2014
  74. 13/18 list-files: add -t backNguyễn Thái Ngọc Duy, Mar 30, 2014
  75. 14/18 list-files: sort output and remove duplicatesNguyễn Thái Ngọc Duy, Mar 30, 2014
  76. 15/18 list-files: do not show duplicate cached entriesNguyễn Thái Ngọc Duy, Mar 30, 2014
  77. 16/18 list-files: show directories as well as filesNguyễn Thái Ngọc Duy, Mar 30, 2014
  78. 17/18 list-files: add -F/--classifyNguyễn Thái Ngọc Duy, Mar 30, 2014
  79. 18/18 list-files -F: show submodules with the new indicator '&'Nguyễn Thái Ngọc Duy, Mar 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.