From: Duy Nguyen Date: Fri, 21 Mar 2014 11:52:43 GMT Subject: Re: [PATCH 3/8] ls_colors.c: enable coloring on u+x files Message-ID: In-Reply-To: On Fri, Mar 21, 2014 at 12:41 AM, Junio C Hamano wrote: > Why even include cache.h for S_IXUSR? > > In the context of the patch I see S_ISGID mentioned and other S_* > st_mode things are already in use in this function before this step, > and presumably you are using them without problems, no? My mistake. git-compat-util.h does include S_IXUSR. The original code was S_IXUGO that's in neither files. -- Duy