Re: [PATCH 7/8] ls-files: support --max-depth

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 28, 2014, 14:15 UTC
Message-ID: <CACsJy8DtW_uUf+G4krc5=EPATNRST3aG9o-bhE34Yb7pw_dXSQ@mail.gmail.com>
In-Reply-To: <vpqtxaiqvl9.fsf@anie.imag.fr>

On Fri, Mar 28, 2014 at 8:52 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 11 quoted lines

> Duy Nguyen <pclouds@gmail.com> writes:
>
>> I'd rather go with no trailing slash by default and add -F (which
>> seems to be more than just '/')
>
> ... and then add a configuration variable to let users enable it by
> default.
>
> For GNU ls, I have "alias ls='ls -F --color=auto'" in my shell's
> configuration, but I cannot push the analogy by aliasing "git ls"
> because Git doesn't allow aliasing existing commands.

I can do that but I want to push for a general solution instead of ls-only. How about config key defaults.<cmd>, containing a list of arguments, that will be prepended to git-<cmd>? Only some commands are marked to support this by adding USE_DEFAULTS in the array commands[] in git.c. And "git --no-defaults <cmd>" will ignore defaults.<cmd> (or "git -c defaults.<cmd>= <cmd>" but it's less obvious). GIT_NO_DEFAULTS can also be set, which has the same effect for all commands.

-- 
Duy