Re: [PATCH v3 4/7] fetch: add --refetch option

From: Robert Coup <robert@coup.net.nz>
Date: Mar 9, 2022, 10:00 UTC
Message-ID: <CACf-nVdER0KGsaBPdcxbM6njy4ek8Ww0cW8KDLOd=bYih7VF8w@mail.gmail.com>
In-Reply-To: <xmqq4k49u0za.fsf@gitster.g>

Hi Junio,

On Mon, 7 Mar 2022 at 17:27, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

>
> You may (or may not --- I didn't look) find options that need to be
> OPT_BOOL() other than "unshallow" one.
>
> While it would be excellent to add a separate "preliminary clean-up"
> step before you add OPT_BOOL("refetch") to fix them to use
> OPT_BOOL() instead of OPT_SET_INT(), that will add extra review
> cycles to the series by extending the scope of it.
>
> It is OK to leave them, in addition to the new one you are adding,
> to use the old and a bit incorrect pattern, as long as you leave a
> prominent note that we need to clean them up later.

I think for this series I will just do a re-roll updating refetch to use OPT_BOOL, and I can do a separate series to look for other existing booleans using OPT_SET_INT.

Rob :)