Re: [PATCH v4 5/7] t5615-partial-clone: add test for fetch --refetch

From: Robert Coup <robert@coup.net.nz>
Date: Apr 1, 2022, 10:36 UTC
Message-ID: <CACf-nVcor-0hbnW-bbRTgXVYJ+Fjd5HkJam7Hh3C=47QwwO6xQ@mail.gmail.com>
In-Reply-To: <220331.86fsmyp2o0.gmgdl@evledraar.gmail.com>

Hi,

On Thu, 31 Mar 2022 at 16:22, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

>
>

> > +
> > +     git -C pc1 fetch --filter=blob:limit=19999 --refetch origin &&
>
> Is 19999 just "arbitrary big number" here?

A selected big number so we can change it and have different objects match.

Show 16 quoted lines

>
> > +     git -C pc1 rev-list --quiet --objects --missing=print \
> > +             main..origin/main >observed &&
> > +     test_line_count = 2 observed &&
> > +
> > +     git -c protocol.version=0 -C pc1 fetch --filter=blob:limit=29999 \
> > +             --refetch origin &&
> > +     git -C pc1 rev-list --quiet --objects --missing=print \
> > +             main..origin/main >observed &&
> > +     test_line_count = 0 observed
>
> Does this test_line_count *really* want to be = 0, or does this mean
> test_must_be_empty?
>
> I.e. are we expecting content here, just not ending in a \n, or nothing
> at all?

I'm expecting no missing objects after a refetch with a new filter that matches all the objects in the repo.

> > +     GIT_TRACE=1 git -C pc1s fetch --filter=blob:limit=999 --refetch origin &&
>
> Why the GIT_TRACE=1? Seems to not be used.

Ah, extraneous debugging on my part.

Thanks, Rob :)