git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] [RFC] partial-clone: add ability to refetch with expanded filter

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Feb 7, 2022, 19:37 UTC
Message-ID
<596fe1fa-2499-665b-007d-c87ca3399d03@jeffhostetler.com>
In-Reply-To
<pull.1138.git.1643730593.gitgitgadget@gmail.com>
On 2/1/22 10:49 AM, Robert Coup via GitGitGadget wrote:
Show 25 quoted lines
> If a filter is changed on a partial clone repository, for example from
> blob:none to blob:limit=1m, there is currently no straightforward way to
> bulk-refetch the objects that match the new filter for existing local
> commits. This is because the client will report commits as "have" during
> negotiation and any dependent objects won't be included in the transferred
> pack. Another use case is discussed at [1].
> 
> This patch series proposes adding a --refilter option to fetch & fetch-pack
> to enable doing a full fetch with a different filter, as if the local has no
> commits in common with the remote. It builds upon cbe566a071
> ("negotiator/noop: add noop fetch negotiator", 2020-08-18).
> 
> To note:
> 
>   1. This will produce duplicated objects between the existing and newly
>      fetched packs, but gc will clean them up.
>   2. This series doesn't check that there's a new filter in any way, whether
>      configured via config or passed via --filter=. Personally I think that's
>      fine.
>   3. If a user fetches with --refilter applying a more restrictive filter
>      than previously (eg: blob:limit=1m then blob:limit=1k) the eventual
>      state is a no-op, since any referenced object already in the local
>      repository is never removed. Potentially this could be improved in
>      future by more advanced gc, possibly along the lines discussed at [2].
> 

Yes, it would be nice to have a way to efficiently extend a partial clone with a more inclusive filter.

It would be nice to be able to send the old filter-spec and the new filter-spec and ask the server to send "new && !old" to keep from having to resend the objects that the client already has. But I'm not sure we know enough (on either side) to make that computation. And as you say, there is no guarantee that the client has only used one filter in the past.

Jeff
Previous: Robert CoupNext: Robert Coup via GitGitGadget
Message 17 of 76 in “[RFC] partial-clone: add ability to refetch with expanded filter”
  1. 0/6 [RFC] partial-clone: add ability to refetch with expanded filterRobert Coup via GitGitGadget, Feb 1, 2022
  2. 1/6 fetch-negotiator: add specific noop initializorRobert Coup via GitGitGadget, Feb 1, 2022
  3. 2/6 fetch-pack: add partial clone refilteringRobert Coup via GitGitGadget, Feb 1, 2022
  4. Jonathan TanFeb 4, 2022
  5. Robert CoupFeb 11, 2022
  6. Jonathan TanFeb 17, 2022
  7. 3/6 builtin/fetch-pack: add --refilter optionRobert Coup via GitGitGadget, Feb 1, 2022
  8. 4/6 fetch: add --refilter optionRobert Coup via GitGitGadget, Feb 1, 2022
  9. 5/6 t5615-partial-clone: add test for --refilterRobert Coup via GitGitGadget, Feb 1, 2022
  10. 6/6 doc/partial-clone: mention --refilter optionRobert Coup via GitGitGadget, Feb 1, 2022
  11. Junio C HamanoFeb 1, 2022
  12. Robert CoupFeb 2, 2022
  13. Robert CoupFeb 16, 2022
  14. Jonathan TanFeb 2, 2022
  15. Robert CoupFeb 2, 2022
  16. Robert CoupFeb 2, 2022
  17. Jeff HostetlerFeb 7, 2022
  18. 0/8 fetch: add repair: full refetch without negotiation (was: "refiltering")Robert Coup via GitGitGadget, Feb 24, 2022
  19. 8/8 doc/partial-clone: mention --repair fetch optionRobert Coup via GitGitGadget, Feb 24, 2022
  20. 3/8 builtin/fetch-pack: add --repair optionRobert Coup via GitGitGadget, Feb 24, 2022
  21. 2/8 fetch-pack: add repairingRobert Coup via GitGitGadget, Feb 24, 2022
  22. Junio C HamanoFeb 25, 2022
  23. Robert CoupFeb 28, 2022
  24. 1/8 fetch-negotiator: add specific noop initializorRobert Coup via GitGitGadget, Feb 24, 2022
  25. Junio C HamanoFeb 25, 2022
  26. Robert CoupFeb 28, 2022
  27. 4/8 fetch: add --repair optionRobert Coup via GitGitGadget, Feb 24, 2022
  28. 5/8 t5615-partial-clone: add test for fetch --repairRobert Coup via GitGitGadget, Feb 24, 2022
  29. 6/8 maintenance: add ability to pass config optionsRobert Coup via GitGitGadget, Feb 24, 2022
  30. Junio C HamanoFeb 25, 2022
  31. Robert CoupFeb 28, 2022
  32. Junio C HamanoFeb 28, 2022
  33. Ævar Arnfjörð BjarmasonFeb 25, 2022
  34. Robert CoupFeb 28, 2022
  35. 7/8 fetch: after repair, encourage auto gc repackingRobert Coup via GitGitGadget, Feb 24, 2022
  36. Ævar Arnfjörð BjarmasonFeb 28, 2022
  37. Ævar Arnfjörð BjarmasonFeb 28, 2022
  38. Robert CoupFeb 28, 2022
  39. Junio C HamanoFeb 28, 2022
  40. Ævar Arnfjörð BjarmasonFeb 28, 2022
  41. 0/7 fetch: add repair: full refetch without negotiation (was: "refiltering")Robert Coup via GitGitGadget, Mar 4, 2022
  42. 1/7 fetch-negotiator: add specific noop initializerRobert Coup via GitGitGadget, Mar 4, 2022
  43. 3/7 builtin/fetch-pack: add --refetch optionRobert Coup via GitGitGadget, Mar 4, 2022
  44. 2/7 fetch-pack: add refetchRobert Coup via GitGitGadget, Mar 4, 2022
  45. 4/7 fetch: add --refetch optionRobert Coup via GitGitGadget, Mar 4, 2022
  46. Junio C HamanoMar 4, 2022
  47. Robert CoupMar 7, 2022
  48. Junio C HamanoMar 7, 2022
  49. Robert CoupMar 9, 2022
  50. 5/7 t5615-partial-clone: add test for fetch --refetchRobert Coup via GitGitGadget, Mar 4, 2022
  51. 6/7 fetch: after refetch, encourage auto gc repackingRobert Coup via GitGitGadget, Mar 4, 2022
  52. 7/7 doc/partial-clone: mention --refetch fetch optionRobert Coup via GitGitGadget, Mar 4, 2022
  53. Calvin WanMar 9, 2022
  54. Robert CoupMar 9, 2022
  55. Junio C HamanoMar 9, 2022
  56. Calvin WanMar 10, 2022
  57. Robert CoupMar 10, 2022
  58. Calvin WanMar 21, 2022
  59. Robert CoupMar 21, 2022
  60. 0/7 fetch: add repair: full refetch without negotiation (was: "refiltering")Robert Coup via GitGitGadget, Mar 28, 2022
  61. 1/7 fetch-negotiator: add specific noop initializerRobert Coup via GitGitGadget, Mar 28, 2022
  62. 2/7 fetch-pack: add refetchRobert Coup via GitGitGadget, Mar 28, 2022
  63. Ævar Arnfjörð BjarmasonMar 31, 2022
  64. Robert CoupApr 1, 2022
  65. 3/7 builtin/fetch-pack: add --refetch optionRobert Coup via GitGitGadget, Mar 28, 2022
  66. 5/7 t5615-partial-clone: add test for fetch --refetchRobert Coup via GitGitGadget, Mar 28, 2022
  67. Ævar Arnfjörð BjarmasonMar 31, 2022
  68. Robert CoupApr 1, 2022
  69. 4/7 fetch: add --refetch optionRobert Coup via GitGitGadget, Mar 28, 2022
  70. Ævar Arnfjörð BjarmasonMar 31, 2022
  71. Robert CoupApr 1, 2022
  72. 6/7 fetch: after refetch, encourage auto gc repackingRobert Coup via GitGitGadget, Mar 28, 2022
  73. Ævar Arnfjörð BjarmasonMar 31, 2022
  74. Robert CoupApr 1, 2022
  75. 7/7 docs: mention --refetch fetch optionRobert Coup via GitGitGadget, Mar 28, 2022
  76. Junio C HamanoMar 28, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.