Re: [PATCH v4 04/44] builtin-am: implement patch queue mechanism

From: Paul Tan <pyokagan@gmail.com>
Date: Jul 7, 2015, 12:50 UTC
Message-ID: <CACRoPnTf7BWeTQPjbS4QfwRCbuMAOzK6=cH=NPPi5ZABn6QyFw@mail.gmail.com>
In-Reply-To: <CAGZ79kYxFceV=w3CQ1xFsT0igy2g=DX2JiV2hwqVLxq-OJ1AOg@mail.gmail.com>

On Mon, Jun 29, 2015 at 1:08 PM, Stefan Beller <sbeller@google.com> wrote:

Show 5 quoted lines

> (optional nit, bikeshedding)
> In conjunction with the previous patch I just wonder when we put a
> TODO and when we want to put a NEEDSWORK, or if we're being
> inconsistent here as both issues will be resolved in a later patch
> in the series.

That's a code style thing that I don't personally have a strong opinion about.

Not sure if the following means anything, but on master,

git grep '\bTODO\b' | wc -l 102

git grep '\bNEEDSWORK\b' | wc -l 45

git log -G'\bTODO\b --oneline | wc -l 185

git log -G'\bNEEDSWORK\b' --oneline | wc -l 120

So it does seem that temporary stuff is usually tagged with "NEEDSWORK", rather than "TODO".

Anyway, it's probably better to be consistent, so I will switch to "NEEDSWORK".

Thanks, Paul