Re: [PATCH v4 01/44] wrapper: implement xopen()
- From
Paul Tan <pyokagan@gmail.com>
- Date
- Jul 1, 2015, 06:05 UTC
- Message-ID
- <CACRoPnSJGhMHX6+4uEGZgN1xYfpY_GeKmux0N3vAkuaQ0rm74A@mail.gmail.com>
- In-Reply-To
- <xmqqr3oubfhz.fsf@gitster.dls.corp.google.com>
On Tue, Jun 30, 2015 at 1:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes: >> 2 remarks: >> - I don't know if and why we need the assert() here (but don't know if >> we have a strategie in Git for assert()) > > There is no bright-line rules, but I think it is sensible to remove > this. Nobody sane would throw a NULL at open(2) and xopen() is > supposed to imitate that interface. We do protect ourselves from > careless use of our own API, but no need to clutter the code with > overly zealous check against insane code, I would say.
Ah, okay. Will remove these assert()s.
Regards, Paul