Re: [RFC 1/5] GSOC: prepare svndump for branch detection

From: David Michael Barr <b@rr-dav.id.au>
Date: Aug 18, 2012, 18:37 UTC
Message-ID: <CACPE+fvkTNNHXbFTwhoH7=aQKoc9YqtfTBOkJDugUogni0sYww@mail.gmail.com>
In-Reply-To: <1345236010-1648-1-git-send-email-florian.achleitner.2.6.31@gmail.com>

On Sat, Aug 18, 2012 at 6:40 AM, Florian Achleitner <florian.achleitner.2.6.31@gmail.com> wrote:

Show 17 quoted lines

> Hi!
>
> This patch series should prepare vcs-svn/svndump.* for branch
> detection. When starting with this feature I found that the existing
> functions are not yet appropriate for that.
> These rewrites the node handling part of svndump.c, it is very
> invasive. The logic in handle_node is not simple, I hope that I
> understood every case the existing code tries to adress.
> At least it doesn't break an existing testcase.
>
> The series applies on top of:
> [PATCH/RFC v4 16/16] Add a test script for remote-svn.
> I could also rebase it onto master if you think it makes sense.
>
> Florian
>
>  [RFC 1/5] vcs-svn: Add sha1 calculaton to fast_export and

This change makes me uncomfortable. We are doubling up on hashing with fast-import. This introduces git-specific logic into vcs-svn.

>  [RFC 2/5] svndump: move struct definitions to .h.
>  [RFC 3/5] vcs-svn/svndump: restructure node_ctx, rev_ctx handling
>  [RFC 4/5] vcs-svn/svndump: rewrite handle_node(),
>  [RFC 5/5] vcs-svn: remove repo_tree

I haven't read the rest of the series yet but I expect it is less controversial than the first patch.

-- David Michael Barr