git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 1/5] GSOC: prepare svndump for branch detection

From
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Date
Aug 20, 2012, 06:26 UTC
Message-ID
<5679616.CtEd2rlvlO@flomedio>
In-Reply-To
<CACPE+fvkTNNHXbFTwhoH7=aQKoc9YqtfTBOkJDugUogni0sYww@mail.gmail.com>
On Sunday 19 August 2012 04:37:35 David Michael Barr wrote:
Show 24 quoted lines
> On Sat, Aug 18, 2012 at 6:40 AM, Florian Achleitner
> 
> <florian.achleitner.2.6.31@gmail.com> wrote:
> > Hi!
> > 
> > This patch series should prepare vcs-svn/svndump.* for branch
> > detection. When starting with this feature I found that the existing
> > functions are not yet appropriate for that.
> > These rewrites the node handling part of svndump.c, it is very
> > invasive. The logic in handle_node is not simple, I hope that I
> > understood every case the existing code tries to adress.
> > At least it doesn't break an existing testcase.
> > 
> > The series applies on top of:
> > [PATCH/RFC v4 16/16] Add a test script for remote-svn.
> > I could also rebase it onto master if you think it makes sense.
> > 
> > Florian
> > 
> >  [RFC 1/5] vcs-svn: Add sha1 calculaton to fast_export and
> 
> This change makes me uncomfortable.
> We are doubling up on hashing with fast-import.
> This introduces git-specific logic into vcs-svn.

You might need to read the rest of the series to see why I did this. Short version: For fast-import, I seperated sending data from the commits, it is sent using the 'blob' command. You have two choices of referencing that blobs later, by using a mark, or by giving their sha1. Marks are already used for marking commits, and there is only one "mark namespace". So I couldn't use marks to reference the blobs in a nice way. This allows for referencing them by their sha1.

Show 8 quoted lines
> 
> >  [RFC 2/5] svndump: move struct definitions to .h.
> >  [RFC 3/5] vcs-svn/svndump: restructure node_ctx, rev_ctx handling
> >  [RFC 4/5] vcs-svn/svndump: rewrite handle_node(),
> >  [RFC 5/5] vcs-svn: remove repo_tree
> 
> I haven't read the rest of the series yet but I expect
> it is less controversial than the first patch.
Hm.. I'm not sure ;)
> 
> --
> David Michael Barr
Florian
Previous: David Michael BarrNext: Junio C Hamano
Message 8 of 12 in “[RFC 1/5] GSOC: prepare svndump for branch detection”
  1. Florian AchleitnerAug 17, 2012
  2. 1/5 vcs-svn: Add sha1 calculaton to fast_export and line_buffer.Florian Achleitner, Aug 17, 2012
  3. 2/5 svndump: move struct definitions to .h.Florian Achleitner, Aug 17, 2012
  4. 3/5 vcs-svn/svndump: restructure node_ctx, rev_ctx handlingFlorian Achleitner, Aug 17, 2012
  5. 4/5 vcs-svn/svndump: rewrite handle_node(), begin|end_revision()Florian Achleitner, Aug 17, 2012
  6. 5/5 vcs-svn: remove repo_treeFlorian Achleitner, Aug 17, 2012
  7. David Michael BarrAug 18, 2012
  8. Florian AchleitnerAug 20, 2012
  9. Junio C HamanoAug 20, 2012
  10. Florian AchleitnerAug 20, 2012
  11. Jonathan NiederAug 20, 2012
  12. Florian AchleitnerAug 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.