git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 1/5] GSOC: prepare svndump for branch detection

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 20, 2012, 06:57 UTC
Message-ID
<7v7gsum4oc.fsf@alter.siamese.dyndns.org>
In-Reply-To
<5679616.CtEd2rlvlO@flomedio>
Florian Achleitner <florian.achleitner.2.6.31@gmail.com> writes:
>> This change makes me uncomfortable.
>> We are doubling up on hashing with fast-import.
>> This introduces git-specific logic into vcs-svn.

IIUC, vcs-svn/fast-export is meant to produce a stream in the fast-import format, and that format is meant to be VCS agnostic, it would need a careful thinking to add anything Git specific to it. If you make other people's importers unable to read from you because you tell them the contents of blob in Git's terms, that is not very good.

> You have two choices of referencing that blobs later, by using a mark, or by 
> giving their sha1. Marks are already used for marking commits, and there is
> only one "mark namespace". So I couldn't use marks to reference the blobs in  
> a nice way. This allows for referencing them by their sha1.

Surely you can, by using even and odd numbers (or modulo 4 if you may later want to mark trees and tags as well, but I doubt that is needed), no?

Previous: Florian AchleitnerNext: Florian Achleitner
Message 9 of 12 in “[RFC 1/5] GSOC: prepare svndump for branch detection”
  1. Florian AchleitnerAug 17, 2012
  2. 1/5 vcs-svn: Add sha1 calculaton to fast_export and line_buffer.Florian Achleitner, Aug 17, 2012
  3. 2/5 svndump: move struct definitions to .h.Florian Achleitner, Aug 17, 2012
  4. 3/5 vcs-svn/svndump: restructure node_ctx, rev_ctx handlingFlorian Achleitner, Aug 17, 2012
  5. 4/5 vcs-svn/svndump: rewrite handle_node(), begin|end_revision()Florian Achleitner, Aug 17, 2012
  6. 5/5 vcs-svn: remove repo_treeFlorian Achleitner, Aug 17, 2012
  7. David Michael BarrAug 18, 2012
  8. Florian AchleitnerAug 20, 2012
  9. Junio C HamanoAug 20, 2012
  10. Florian AchleitnerAug 20, 2012
  11. Jonathan NiederAug 20, 2012
  12. Florian AchleitnerAug 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.