Re: I18N.pm is incompatible with perl < 5.8.3

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Feb 2, 2012, 16:48 UTC
Message-ID: <CACBZZX5YuN8vpmTiP_38Aa=c3KDqEHCKBX3DE2YKkeMCdR4GBg@mail.gmail.com>
In-Reply-To: <4F2A8B78.6090902@statsbiblioteket.dk>

On Thu, Feb 2, 2012 at 14:11, Tom G. Christensen <tgc@statsbiblioteket.dk> wrote:

> Hello,
>

Thanks Tom, I'll submit a patch for that. Does this work, i.e. does 5.8.3 need *{import} = instead of *import = ?

    diff --git a/perl/Git/I18N.pm b/perl/Git/I18N.pm
    index 07597dc..5bcfed5 100644
    --- a/perl/Git/I18N.pm
    +++ b/perl/Git/I18N.pm
    @@ -2,7 +2,16 @@ package Git::I18N;
     use 5.008;
     use strict;
     use warnings;
    -use Exporter 'import';
    +BEGIN {
    +       require Exporter;
    +       if ($] < 5.008003) {
    +               *import = \&Exporter::import;
    +       } else {
    +               # Exporter 5.57 supporting this invocation was released with
    +               # 5.8.3
    +               Exporter->import('import');
    +       }
    +}

     our @EXPORT = qw(__);
     our @EXPORT_OK = @EXPORT;

But actually it might be better to check $Exporter::VERSION